From 223f48d7adf82f114be16cfbc43830e344e702fe Mon Sep 17 00:00:00 2001 From: Thiago Perrotta Date: Thu, 23 Feb 2023 23:19:57 +0000 Subject: [PATCH] git cl split: recognize bug patterns of the form "Bug: chromium:123" Currently, only the "Bug: 123" form is recognized. Bug: none Change-Id: I4348779bb14f4c02bb8781ce4fe2bd55892e8cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4289407 Commit-Queue: Thiago Perrotta Reviewed-by: Dirk Pranke --- split_cl.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/split_cl.py b/split_cl.py index 9afc3d358..433352ffa 100644 --- a/split_cl.py +++ b/split_cl.py @@ -248,8 +248,10 @@ def SplitCl(description_file, comment_file, changelist, cmd_upload, dry_run, if answer.lower() != 'y': return 0 - # Verify that the description contains a bug link. - bug_pattern = re.compile(r"^Bug:\s*[0-9]+", re.MULTILINE) + # Verify that the description contains a bug link. Examples: + # Bug: 123 + # Bug: chromium:456 + bug_pattern = re.compile(r"^Bug:\s*(?:[a-zA-Z]+:)?[0-9]+", re.MULTILINE) matches = re.findall(bug_pattern, description) answer = 'y' if not matches: