From 1f33a15831b8d56edccc80ac66f80e2943c598f1 Mon Sep 17 00:00:00 2001 From: Brian Ryner Date: Thu, 14 Aug 2025 09:16:12 -0700 Subject: [PATCH] Use gclient_utils.rmtree() when updating a GCS dep to handle readonly files on Windows. Bug: 438515314 Change-Id: I84848b9589dbe761be0dc7d8427a1dd317d70da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6851010 Auto-Submit: Brian Ryner Reviewed-by: Gavin Mak Commit-Queue: Gavin Mak --- gclient.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gclient.py b/gclient.py index d637db468b..0fc2fa62d0 100755 --- a/gclient.py +++ b/gclient.py @@ -849,7 +849,7 @@ class Dependency(gclient_utils.WorkItem, DependencySettings): # exist. logging.warning( 'GCS dependency %s new version, removing old.', name) - shutil.rmtree(gcs_deps[0].output_dir) + gclient_utils.rmtree(gcs_deps[0].output_dir) else: url = dep_value.get('url') deps_to_add.append(