From 18630d61d24acb3d80c70371d356d452c3faa026 Mon Sep 17 00:00:00 2001 From: "tandrii@chromium.org" Date: Fri, 4 Mar 2016 12:06:02 +0000 Subject: [PATCH] Gerrit: announce deprecation of auto-download of commit-msg hook. BUG=579176 Review URL: https://codereview.chromium.org/1764453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299095 0039d316-1c4b-4281-b951-d872f2087c98 --- git_cl.py | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/git_cl.py b/git_cl.py index 8f71fd598..62b542c6b 100755 --- a/git_cl.py +++ b/git_cl.py @@ -602,9 +602,9 @@ class Settings(object): if autoupdate != 'false' and cr_settings_file: LoadCodereviewSettingsFromFile(cr_settings_file) # set updated to True to avoid infinite calling loop - # through DownloadHooks + # through DownloadGerritHook self.updated = True - DownloadHooks(False) + DownloadGerritHook(False) self.updated = True def GetDefaultServerUrl(self, error_ok=False): @@ -1570,8 +1570,8 @@ def hasSheBang(fname): return f.read(2).startswith('#!') -def DownloadHooks(force): - """downloads hooks +def DownloadGerritHook(force): + """Download and install Gerrit commit-msg hook. Args: force: True to update hooks. False to install hooks if not present. @@ -1585,6 +1585,10 @@ def DownloadHooks(force): if not force: return try: + print( + 'WARNING: installing Gerrit commit-msg hook.\n' + ' This behavior of git cl will soon be disabled.\n' + ' See bug http://crbug.com/579176.') urlretrieve(src, dst) if not hasSheBang(dst): DieWithError('Not a script: %s\n' @@ -1623,7 +1627,7 @@ def CMDconfig(parser, args): if len(args) == 0: GetCodereviewSettingsInteractively() - DownloadHooks(True) + DownloadGerritHook(True) return 0 url = args[0] @@ -1632,7 +1636,7 @@ def CMDconfig(parser, args): # Load code review settings and download hooks (if available). LoadCodereviewSettingsFromFile(urllib2.urlopen(url)) - DownloadHooks(True) + DownloadGerritHook(True) return 0