From 17f9e1f7dc9f0e745a08e7ac419bc72843978c63 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Wed, 2 Feb 2011 21:04:26 +0000 Subject: [PATCH] Add comment to clarify SHOULD_LEAK NO CODE CHANGE. BUG=none TEST=none Review URL: http://codereview.chromium.org/6349053 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@73510 0039d316-1c4b-4281-b951-d872f2087c98 --- tests/fake_repos.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/fake_repos.py b/tests/fake_repos.py index 55fd976b6..8674aca56 100755 --- a/tests/fake_repos.py +++ b/tests/fake_repos.py @@ -208,7 +208,10 @@ class FakeReposBase(object): populateSvn() and populateGit() need to be implemented by the subclass. """ - # Should leak the repositories. + # When SHOULD_LEAK is set to True, temporary directories created while the + # tests are running aren't deleted at the end of the tests. Expect failures + # when running more than one test due to inter-test side-effects. Helps with + # debugging. SHOULD_LEAK = False # Override if unhappy. TRIAL_DIR = None @@ -725,8 +728,8 @@ def main(argv): return 0 -# Kind of hack. if '-l' in sys.argv: + # See SHOULD_LEAK definition in FakeReposBase for its purpose. FakeReposBase.SHOULD_LEAK = True print 'Leaking!' sys.argv.remove('-l')