From 171c07458e2f624b26c3f82d70e51676ffa9a31f Mon Sep 17 00:00:00 2001 From: Mohamed Heikal Date: Fri, 9 Nov 2018 20:38:51 +0000 Subject: [PATCH] Fix crash were CL has no reviewers Currently git cl owners tries to fetch the current reviewers of a CL from gerrit. However, this fails with a KeyError when there are no reviewers currently. This cl fixes that bug. Bug: 895722 Change-Id: I78a998ee234d207523aa2cef4b5058ba7cfecbc2 Reviewed-on: https://chromium-review.googlesource.com/c/1330122 Commit-Queue: Mohamed Heikal Reviewed-by: Dirk Pranke --- git_cl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git_cl.py b/git_cl.py index e8f7e5535..4dd1cd3b5 100755 --- a/git_cl.py +++ b/git_cl.py @@ -3156,7 +3156,7 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase): def GetReviewers(self): details = self._GetChangeDetail(['DETAILED_ACCOUNTS']) - return [reviewer['email'] for reviewer in details['reviewers']['REVIEWER']] + return [r['email'] for r in details['reviewers'].get('REVIEWER', [])] _CODEREVIEW_IMPLEMENTATIONS = {