From 16b514092cf8b7571963489cf1d6348ef991cabc Mon Sep 17 00:00:00 2001 From: "iannucci@chromium.org" Date: Sun, 17 Feb 2013 05:33:36 +0000 Subject: [PATCH] Fix parameters for git_cl and gcl. TBR=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/12300005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@183022 0039d316-1c4b-4281-b951-d872f2087c98 --- gcl.py | 3 ++- git_cl.py | 2 +- tests/gcl_unittest.py | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gcl.py b/gcl.py index 56655c294c..ce6edabab2 100755 --- a/gcl.py +++ b/gcl.py @@ -1045,7 +1045,8 @@ def CMDcommit(change_info, args): elif revision: change_info.description += "\nCommitted: " + revision change_info.CloseIssue() - props = change_info.RpcServer().get_issue_properties(change_info.issue) + props = change_info.RpcServer().get_issue_properties( + change_info.issue, False) patch_num = len(props['patchsets']) comment = "Committed patchset #%d manually as r%s" % (patch_num, revision) comment += ' (presubmit successful).' if not bypassed else '.' diff --git a/git_cl.py b/git_cl.py index e515f89b00..11266914aa 100755 --- a/git_cl.py +++ b/git_cl.py @@ -1495,7 +1495,7 @@ def SendUpstream(parser, args, cmd): print ('Closing issue ' '(you may be prompted for your codereview password)...') cl.CloseIssue() - props = cl.RpcServer().get_issue_properties(cl.GetIssue()) + props = cl.RpcServer().get_issue_properties(cl.GetIssue(), False) patch_num = len(props['patchset']) comment = "Committed patchset #%d manually as r%s" % (patch_num, revision) comment += ' (presubmit successful).' if not options.bypass_hooks else '.' diff --git a/tests/gcl_unittest.py b/tests/gcl_unittest.py index 77cc56fb22..ddaab3a82b 100755 --- a/tests/gcl_unittest.py +++ b/tests/gcl_unittest.py @@ -59,7 +59,8 @@ class GclTestsBase(SuperMoxTestBase): change_info._comments_added = [] class RpcServer(object): - def get_issue_properties(self, *_): # pylint: disable=R0201 + # pylint: disable=R0201,W0613 + def get_issue_properties(self, issue, messages): return { 'patchsets': [1337] } change_info.RpcServer = RpcServer