From 11d847f07bd10fdc952ed11278998dd6fc0f7c68 Mon Sep 17 00:00:00 2001 From: Aravind Vasudevan Date: Fri, 7 Jul 2023 19:35:12 +0000 Subject: [PATCH] Fix setdep to run git command only for submodules is enabled Change-Id: If748b0cb63e35fe68b608ccdb147a1728d3ae42c Bug: 1463007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4671611 Commit-Queue: Josip Sokcevic Auto-Submit: Aravind Vasudevan Reviewed-by: Josip Sokcevic --- gclient.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gclient.py b/gclient.py index 003afca4f4..8edc889631 100755 --- a/gclient.py +++ b/gclient.py @@ -3413,9 +3413,11 @@ def CMDsetdep(parser, args): builtin_vars=builtin_vars) # Create a set of all git submodules. - submodule_status = subprocess2.check_output(['git', 'submodule', - 'status']).decode('utf-8') - git_modules = {l.split()[1] for l in submodule_status.splitlines()} + if 'git_dependencies' in local_scope and local_scope['git_dependencies'] in ( + gclient_eval.SUBMODULES, gclient_eval.SYNC): + submodule_status = subprocess2.check_output(['git', 'submodule', + 'status']).decode('utf-8') + git_modules = {l.split()[1] for l in submodule_status.splitlines()} for var in options.vars: name, _, value = var.partition('=')