From 10bd39fd47865eb6c9af749e4d30e8ec5d06451f Mon Sep 17 00:00:00 2001 From: Michael Savigny Date: Tue, 30 Jan 2024 21:29:44 +0000 Subject: [PATCH] Enable deps cache for windows builds. On my windows cloudtop, without deps cache a build of chrome took around 2130s, with it enabled (and populated) a build took around 1665s, which is about a 7-8 minute improvement. Bug: b/320457907 Change-Id: I82232cad57152f1a10d1e262125290d54bf8ab33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5249053 Reviewed-by: Ben Segall Commit-Queue: Michael Savigny --- reclient_helper.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/reclient_helper.py b/reclient_helper.py index 9f1093382..9e57c16d6 100644 --- a/reclient_helper.py +++ b/reclient_helper.py @@ -258,6 +258,11 @@ def set_mac_defaults(): os.environ.setdefault("RBE_cas_concurrency", "100") +def set_win_defaults(): + # Enable the deps cache on windows. This makes a notable improvement + # in performance at the cost of a ~200MB cache file. + os.environ.setdefault("RBE_enable_deps_cache", "true") + @contextlib.contextmanager def build_context(argv, tool): # If use_remoteexec is set, but the reclient binaries or configs don't @@ -297,6 +302,8 @@ def build_context(argv, tool): set_racing_defaults() if sys.platform == "darwin": set_mac_defaults() + if sys.platform.startswith("win"): + set_win_defaults() # TODO(b/292523514) remove this once a fix is landed in reproxy remove_mdproxy_from_path()