From 1069d421d9bbd8dd1ca00efb53ffbb5d1265dca9 Mon Sep 17 00:00:00 2001 From: John Budorick Date: Wed, 14 Aug 2019 18:00:33 +0000 Subject: [PATCH] presubmit: add a one hour timeout to bot_update. Mirroring crrev.com/c/1717663. bot_update runs that take more than an hour are typically hung in irrecoverable ways. Recipe-Nontrivial-Roll: build Change-Id: Ic0afc48db7e0ac3464888e7715621a04f55443ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754263 Reviewed-by: Stephen Martinis Reviewed-by: Haiyang Pan Reviewed-by: Nodir Turakulov Commit-Queue: John Budorick Auto-Submit: John Budorick --- recipes/recipe_modules/presubmit/api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recipes/recipe_modules/presubmit/api.py b/recipes/recipe_modules/presubmit/api.py index 9fbb7f7d56..c6690dee1e 100644 --- a/recipes/recipe_modules/presubmit/api.py +++ b/recipes/recipe_modules/presubmit/api.py @@ -52,7 +52,7 @@ class PresubmitApi(recipe_api.RecipeApi): """ # Expect callers to have already set up their gclient configuration. - bot_update_step = self.m.bot_update.ensure_checkout() + bot_update_step = self.m.bot_update.ensure_checkout(timeout=3600) relative_root = self.m.gclient.get_gerrit_patch_root().rstrip('/') abs_root = self.m.context.cwd.join(relative_root)