From 0be4724e2f4ff9e4a02c63a69d2d40b4b0aac56c Mon Sep 17 00:00:00 2001 From: Ayu Ishii Date: Sat, 11 Jul 2020 00:44:54 +0000 Subject: [PATCH] CodeInclusion: Rename whitelist/blacklist -> allowlist/blocklist Bug: 1097674 Change-Id: Ib1a4a3fe3eca37a1a3a90d62c19eeda5fe4bc499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2293134 Reviewed-by: Josip Sokcevic Commit-Queue: Ayu Ishii --- tests/presubmit_unittest.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py index b3c1a9bb5..4575b9c90 100755 --- a/tests/presubmit_unittest.py +++ b/tests/presubmit_unittest.py @@ -1241,8 +1241,8 @@ class InputApiUnittest(PresubmitTestsBase): self.assertEqual(got_files[4].LocalPath(), presubmit.normpath(files[4][1])) self.assertEqual(got_files[5].LocalPath(), presubmit.normpath(files[5][1])) self.assertEqual(got_files[6].LocalPath(), presubmit.normpath(files[6][1])) - # Ignores weird because of whitelist, third_party because of blacklist, - # binary isn't a text file and beingdeleted doesn't exist. The rest is + # Ignores weird because of check_list, third_party because of skip_list, + # binary isn't a text file and being deleted doesn't exist. The rest is # outside foo/. rhs_lines = [x for x in input_api.RightHandSideLines(None)] self.assertEqual(len(rhs_lines), 14) @@ -1298,7 +1298,7 @@ class InputApiUnittest(PresubmitTestsBase): self.assertEqual(got_files[2].LocalPath(), presubmit.normpath(files[5][1])) self.assertEqual(got_files[3].LocalPath(), presubmit.normpath(files[7][1])) - def testDefaultWhiteListBlackListFilters(self): + def testDefaultFilesToCheckFilesToSkipFilters(self): def f(x): return presubmit.AffectedFile(x, 'M', self.fake_root_dir, None) files = [ @@ -3186,8 +3186,8 @@ the current line as well! input_api, presubmit.OutputApi, 'random_directory', - whitelist=['^a$', '^b$'], - blacklist=['a']) + files_to_check=['^a$', '^b$'], + files_to_skip=['a']) self.assertEqual(1, len(results)) self.assertEqual( presubmit.OutputApi.PresubmitNotifyResult, results[0].__class__)