From 07d44398a2856cf88db1f4309f5d1f4e1d9945b7 Mon Sep 17 00:00:00 2001 From: "jam@chromium.org" Date: Wed, 12 Sep 2012 16:59:22 +0000 Subject: [PATCH] Switch gcl/git upload to use https://codereview.chromium.org instead of https://chromiumcodereview.appspot.com. It's been a week since the SSL certificate got added, and the old DNS records had a TTL of 7 days. Review URL: https://chromiumcodereview.appspot.com/10910225 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@156316 0039d316-1c4b-4281-b951-d872f2087c98 --- gclient_utils.py | 3 --- tests/gclient_utils_test.py | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/gclient_utils.py b/gclient_utils.py index c24be5229..ab45d28cc 100644 --- a/gclient_utils.py +++ b/gclient_utils.py @@ -752,9 +752,6 @@ def UpgradeToHttps(url): # Do not automatically upgrade http to https if a port number is provided. if parsed[0] == 'http' and not re.match(r'^.+?\:\d+$', parsed[1]): parsed[0] = 'https' - # Until GAE supports SNI, manually convert the url. - if parsed[1] == 'codereview.chromium.org': - parsed[1] = 'chromiumcodereview.appspot.com' return urlparse.urlunparse(parsed) diff --git a/tests/gclient_utils_test.py b/tests/gclient_utils_test.py index d5c0c4ba3..8dc69090f 100755 --- a/tests/gclient_utils_test.py +++ b/tests/gclient_utils_test.py @@ -181,8 +181,8 @@ class GClientUtilsTest(trial_dir.TestCase): ['foo/', 'https://foo/'], ['ssh-svn://foo', 'ssh-svn://foo'], ['ssh-svn://foo/bar/', 'ssh-svn://foo/bar/'], - ['codereview.chromium.org', 'https://chromiumcodereview.appspot.com'], - ['codereview.chromium.org/', 'https://chromiumcodereview.appspot.com/'], + ['codereview.chromium.org', 'https://codereview.chromium.org'], + ['codereview.chromium.org/', 'https://codereview.chromium.org/'], ['http://foo:8080', 'http://foo:8080'], ['http://foo:8080/bar', 'http://foo:8080/bar'], ['foo:8080', 'http://foo:8080'],