From 07d24776f240ad2b46def46b2023f28e600a1c40 Mon Sep 17 00:00:00 2001 From: Allen Li Date: Tue, 8 Apr 2025 14:15:24 -0700 Subject: [PATCH] [git_auth] Emphasize success People assume the tool has failed and keep trying to re-run it when it says to run git credential-luci login. Bug: 408501013 Change-Id: Id1f671bacfdc19d4614ff03cfa69bfd484ad741b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6441970 Reviewed-by: Yiwei Zhang Commit-Queue: Allen Li --- git_auth.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/git_auth.py b/git_auth.py index fed40ae40..3a916337a 100644 --- a/git_auth.py +++ b/git_auth.py @@ -492,6 +492,8 @@ class ConfigWizard(object): 'Looks like we are running outside of a Gerrit repository,') self._println('so we will check your global Git configuration.') self._run_outside_repo() + self._println() + self._println('Successfully finished auth configuration check.') self._print_actions_for_user() def _run_outside_repo(self) -> None: @@ -851,7 +853,9 @@ class ConfigWizard(object): if not self._user_actions: return self._println() - self._println('Things you need to do:') + self._println( + "However, there are some manual actions that are suggested") + self._println("(you don't have to re-run this command afterward):") for s in self._user_actions: self._println(f'- {s}')