From 00fc72856bb0a8f5889409c992b8123e79a852a6 Mon Sep 17 00:00:00 2001 From: Mun Yong Jang Date: Wed, 15 Nov 2017 09:39:09 -0800 Subject: [PATCH] [presubmit] Rename to CheckChangedLUCIConfigs Bug: 785114 Change-Id: I53c3b4e54f39f4bacf8fb0bda1de4e4b0e1b280b Reviewed-on: https://chromium-review.googlesource.com/771592 Reviewed-by: Nodir Turakulov Commit-Queue: Mun Yong Jang --- presubmit_canned_checks.py | 5 +++++ tests/presubmit_unittest.py | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index 21bb407b3..39cc5abe7 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -39,7 +39,12 @@ BLACKLIST_LINT_FILTERS = [ ### Description checks +# TODO(myjang): Remove this once all presubmit scripts use the other def CheckChangedConfigs(input_api, output_api): + return CheckChangedLUCIConfigs(input_api, output_api) + + +def CheckChangedLUCIConfigs(input_api, output_api): import collections import base64 import json diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py index 9238ffc77..6c982e9e8 100755 --- a/tests/presubmit_unittest.py +++ b/tests/presubmit_unittest.py @@ -1800,7 +1800,7 @@ class CannedChecksUnittest(PresubmitTestsBase): 'GetPythonUnitTests', 'GetPylint', 'GetUnitTests', 'GetUnitTestsInDirectory', 'GetUnitTestsRecursively', 'CheckCIPDManifest', 'CheckCIPDPackages', - 'CheckChangedConfigs', + 'CheckChangedLUCIConfigs', 'CheckChangedConfigs', ] # If this test fails, you should add the relevant test. self.compareMembers(presubmit_canned_checks, members) @@ -1963,7 +1963,7 @@ class CannedChecksUnittest(PresubmitTestsBase): "TODO(foo): bar", None, "TODO: bar", None, presubmit.OutputApi.PresubmitPromptWarning) - def testCannedCheckChangedConfigs(self): + def testCannedCheckChangedLUCIConfigs(self): affected_file1 = self.mox.CreateMock(presubmit.GitAffectedFile) affected_file1.LocalPath().AndReturn('foo.cfg') affected_file1.NewContents().AndReturn(['test', 'foo']) @@ -2006,7 +2006,7 @@ class CannedChecksUnittest(PresubmitTestsBase): self.mox.ReplayAll() - results = presubmit_canned_checks.CheckChangedConfigs( + results = presubmit_canned_checks.CheckChangedLUCIConfigs( input_api, presubmit.OutputApi) self.assertEquals(len(results), 1)