From 0f2cdf1c6fd8f994405db89437b87802c288a8a2 Mon Sep 17 00:00:00 2001
From: Samuel Rowe <samuelrowe1999@gmail.com>
Date: Tue, 19 Jul 2022 21:54:15 +0530
Subject: [PATCH] refactor(frontend): minor changes to make code more readable

---
 .../src/components/Modal/Service/Create.tsx    |  8 ++------
 services/frontend/src/utils/index.ts           | 18 ++++++------------
 2 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/services/frontend/src/components/Modal/Service/Create.tsx b/services/frontend/src/components/Modal/Service/Create.tsx
index 87a86cd..954873c 100644
--- a/services/frontend/src/components/Modal/Service/Create.tsx
+++ b/services/frontend/src/components/Modal/Service/Create.tsx
@@ -7,7 +7,7 @@ import Environment from "./Environment";
 import Volumes from "./Volumes";
 import Labels from "./Labels";
 import { serviceConfigCanvasInitialValues } from "../../../utils";
-import { CallbackFunction, ICanvasConfig, IService } from "../../../types";
+import { CallbackFunction } from "../../../types";
 
 interface IModalServiceProps {
   onHide: CallbackFunction;
@@ -18,7 +18,6 @@ const ModalServiceCreate = (props: IModalServiceProps) => {
   const { onHide, onAddEndpoint } = props;
   const [openTab, setOpenTab] = useState("General");
   const handleCreate = (values: any, formik: any) => {
-    console.log(values);
     onAddEndpoint(values);
     formik.resetForm();
   };
@@ -103,7 +102,6 @@ const ModalServiceCreate = (props: IModalServiceProps) => {
               }}
               enableReinitialize={true}
               onSubmit={(values, formik) => {
-                console.log(values);
                 handleCreate(values, formik);
               }}
               validationSchema={validationSchema}
@@ -148,9 +146,7 @@ const ModalServiceCreate = (props: IModalServiceProps) => {
                     <button
                       className="btn-util"
                       type="button"
-                      onClick={() => {
-                        formik.submitForm();
-                      }}
+                      onClick={formik.submitForm}
                     >
                       Add
                     </button>
diff --git a/services/frontend/src/utils/index.ts b/services/frontend/src/utils/index.ts
index ebd59eb..13bae4f 100644
--- a/services/frontend/src/utils/index.ts
+++ b/services/frontend/src/utils/index.ts
@@ -106,17 +106,10 @@ export const attachUUID = (key: string): string => {
   return key + "-" + uuidv4();
 };
 
-export const setNodeIcon = (nodeType: string) => {
-  switch (nodeType) {
-    case "service":
-      return "ServerIcon";
-    case "volume":
-      return "DatabaseIcon";
-    case "network":
-      return "ChipIcon";
-    default:
-      return "ServerIcon";
-  }
+export const iconByNodeType: Record<string, string> = {
+  service: "ServerIcon",
+  volume: "DatabaseIcon",
+  network: "ChipIcon"
 };
 
 export const getClientNodeItem = (
@@ -129,7 +122,8 @@ export const getClientNodeItem = (
     nodeItem.canvasConfig.node_icon &&
     nodeItem.canvasConfig.node_icon.length === 0
   ) {
-    nodeItem.canvasConfig.node_icon = setNodeIcon(nodeItem.type);
+    nodeItem.canvasConfig.node_icon =
+      iconByNodeType[nodeItem.type] || "ServerIcon";
   }
 
   return {