1507 Commits (fac0c90de18cc41247b1bf6c5bb786c9689cac0d)

Author SHA1 Message Date
Adriaan de Groot 1eba562d07 [partition] Apply coding style 4 years ago
shainer 1007680931 Fix error handling in ChangeFilesystemLabelJob 4 years ago
shainer c035029f38 Make sure we always set the filesystem label.
In particular, we need a separate Job class to set the label; this
is invoked after we formatted a partition, and when no other changes
to the partition have been requested in the Edit dialog.
4 years ago
Adriaan de Groot 3d49379bec [partition] Chase API change in createNewPartition()
The partition- and filesystem-label setting code was already there,
but not in the call to createNewPartition(); now we set the
FS label twice (once in the call, once afterwards)
4 years ago
shainer b602d423c7 Allow users to set/edit filesystem labels.
When creating or editing a new formatted partition, allow
to set a filesystem label (16 chars maximum). Modify
the KPMHelpers to accept it as a new parameter. Partitions
created by default may get a meaningful label too.
4 years ago
shainer 1cfdc8044c Display current filesystem label as a column in the main partition view. 4 years ago
Adriaan de Groot 559b79f920 [partition] Use (better documented) filesystem-use API 4 years ago
Adriaan de Groot 186d32ebee [partition] More missing ; 4 years ago
Adriaan de Groot 2b4bc7adf4 [partition] Apply newer formatting tool 4 years ago
Adriaan de Groot bb426ebac4 [partition] Add missing ; (and apply coding style) 4 years ago
Adriaan de Groot 98524708cc [partition] Chase namespace change for Units 4 years ago
Adriaan de Groot 144b51f00e [partition] Use automount control
FIXES #1604

(Admittedly, this fixes the problem only when there's Plasma Solid automount
present, and not any of the other kinds; but none of those have been reported
yet, and adding them into AutoMount.cpp is opaque to the rest of the
system)
4 years ago
Adriaan de Groot 17f73b1294 [partition] Test automount job in a queue 4 years ago
Adriaan de Groot 38fa1d9567 [libcalamares] Distinguish logging raw, shared and unique pointers
- It shouldn't be necessary to explicitly .get() pointers for
  logging, and it's convenient to know when a pointer is smart.
  * no annotation means raw (e.g. @0x0)
  * S means shared
  * U means unique
4 years ago
Adriaan de Groot c43a6ab866 [partition] Improve logging in automount test
- switch logging in job to VERBOSE because we don't want to be printing
  pointers to the regular session log
- switch logging in test to VERBOSE to actually see the messages from the Job
- hook the test into the build
4 years ago
Adriaan de Groot aae815cf3b [partition] Add trivial test for automount management job 4 years ago
Adriaan de Groot 1704ad5977 [partition] Add a job to handle automount behavior
- while here, nudge CalamaresUtils automount API a little,
  since it doesn't really need an rvalue-ref.
4 years ago
Adriaan de Groot 6978ce3cb4 [partition] Collect more kpmcore 4.2 code 4 years ago
Adriaan de Groot 520f08bbba [partition] Fix build with legacy kpmcore 4 years ago
Adriaan de Groot 31bf38977e [partition] Refactor partition-labeling 4 years ago
Gaël PORTAY af5c57a713 [partition] Output filesystem features in overview 4 years ago
Gaël PORTAY c045af1975 [partition] Output GPT entries in overview 4 years ago
Gaël PORTAY bf9c9a64f1 [libcalamares] Introduce new function getPartitionTable 4 years ago
Gaël PORTAY feab8bebba [partition] Remove unused attribute m_defaultFsType
This attribute is used since the commit fcd0e8d36 [partition] Apply
partition layout when replacing free space
4 years ago
Gaël PORTAY 2e6d632c7c [partition] Fix typo 4 years ago
Adriaan de Groot 59255c7a57 Changes: apply coding style 4 years ago
Gaël PORTAY e2b00bc517 [partition] Fix typo 4 years ago
Adriaan de Groot 2c297a068f [partition] Log when an EFI problem has been solved 4 years ago
Adriaan de Groot 0f38ee624e [partition] static-assert that our shortcut makes sense 4 years ago
Adriaan de Groot 15ace5202d [partition] Simplify EFI-flags checking with KPMCore 4 4 years ago
Adriaan de Groot 85bb8c27b3 [partition] Simplify flags calculations
- factor out the flags-we-want from the flags-we-already-have
 - the use of ->activeFlags() meant that the state on *disk* was
   being compared with the flags-we-want; if a partition was re-edited,
   then you couldn't change the flags back to the state-on-disk
   (eg. enable a flag, then change your mind and disable it).
 - set the flags before refreshing the partition, because the
   refresh checks for EFI bootability and that needs the new flags,
   not the old ones.
4 years ago
Adriaan de Groot 949e33f1e8 [partition] Massage logging while checking for EFI boot 4 years ago
Adriaan de Groot 63964de4bd [partition] Explain underlying type for flags variant 4 years ago
Adriaan de Groot 87c77d9807 [partition] When flags are explicitly invalid, return early 4 years ago
Adriaan de Groot 356e13ae93 [partition] Improve logging readability 4 years ago
Adriaan de Groot 2516f18d1b
Merge pull request #1560 from gportay/partition-mount-make-mountPoint-and-filesystem-optionals
[partition,mount] Make mountPoint and filesystem optionals
4 years ago
Adriaan de Groot ffce79e30e [partition] Initialize the filesystem type, not the partition type
- Passing FileSystem::Type to the QString constructor for
  partition type is not what I intended.
4 years ago
Adriaan de Groot 73b5a0898d [partition] Migrate the defaultFS type
- remove the m_defaultFSType from PartitionLayout, because it is
  set on construction -- which is too early, before the configuration
  has been read.
- make the default FS explicit in the init() calls which pass in
  a configuration; this needs support in the intermediate
  PartitionCoreModule.
4 years ago
Adriaan de Groot 23eabd74c6 [partition] Set FS type explicitly if no layout is given
- the "simple" constructor for PartitionEntry left the FS type
  set as the constructor left it -- which is Unknown by default.
  This leads to install failures in systems that don't set a
  special layout but just want a single / -- because the FS is
  set to Unknown.
- massage the constructor and consumer of the code, push
  Ext4 FS in the tests and use the configured default in production.
4 years ago
Adriaan de Groot f78752303b [partition] Improve constructors for layout
- initialize flags by default
- the copy constructor was just doing the default thing,
  so make that explicit
4 years ago
Gaël PORTAY 6013ed52f8 [partition] Ignore unformatted filesystem 4 years ago
Gaël PORTAY db08d2db8b [partition] Make filesystem optional and default to unformatted 4 years ago
Gaël PORTAY 1f9f506a16 [partition] Make mountPoint optional
Some devices cannot be mounted (as DM_verity_hash), therefore, it is
nosense to set a mountPoint for them.
4 years ago
Adriaan de Groot 10991346b7
Merge pull request #1561 from gportay/partition-set-swap-partition-name
[partition] Allow a configurable swap Partition name
4 years ago
Adriaan de Groot 7578768c46
Merge pull request #1562 from gportay/partition-group-efi-things-together
[partition] Group EFI things together
4 years ago
Adriaan de Groot 0bad5469fc [libcalamares] Fix tests failures from JobQueue asserts
Some compile flags changed recently, triggering assert()
in the jobqueue when there is more than one. There's no
real reason for JobQueue to be a singleton, but it wants
to be. So clean up pointers a little more enthusiastically.
4 years ago
Adriaan de Groot 4a08fdbb92 [partition] Reduce warnings from KPMCore
- make KPMHelper.h an "everything include" and suppress warnings
  from it, then use it in the tests.
4 years ago
Adriaan de Groot d26fde6647 [partition] Reduce warnings
- Add a helper header that munges the warnings-settings so that
  KPMcore headers can be included.
4 years ago
Adriaan de Groot 4d444cbfbb [partition] Reduce warnings (Clang, FreeBSD)
The code doesn't match the comment: there are no by-ref captures
in the code, and the shadowing of parameters and local variables
is confusing. Remove one variable that is passed in as an argument
(and just pass the value as argument) and copy-capture the other
rather than doing weird argument passing.
4 years ago
Adriaan de Groot 0a44ce381e [partition] Reduce warnings (Clang, FreeBSD)
- remove unused this captures from lambda
- rename variables that are short, cryptic, and shadowed
- remove documentation for parameters that don't exist
4 years ago