7131 Commits (dbde6149ac5dc42a3e2b8171382b7390c66f00b6)
 

Author SHA1 Message Date
Adriaan de Groot e8408cb5b2 [partition] Fix include path type
- Don't use #include <> for files in the current source directory.
6 years ago
Adriaan de Groot 4df9bd8917 [partition] Use KPM manager in partitioning jobs
- This gives all the partition-changing jobs an easy way to
   manage the lifetime of the privileged helper.
6 years ago
Adriaan de Groot ed999a247a [fsresizer] Use partition service
- Don't need to initialize KPMCore ourself.
 - Simplify error paths.
6 years ago
Adriaan de Groot d0d017f5fe [libcalamares] Add convenience backend() to KPMManager 6 years ago
Adriaan de Groot d039f9bbb8 [partition] Remove initKPMCore() from KPMHelpers
- This is a job for KPMManager, from the partition service.
 - In tests, needs to be a little hackish.
6 years ago
Adriaan de Groot a01539b664 [libcalamares] Fix memory ownership of KPMManager
- The InternalManager object should have at most one living
   instance at a time.
 - getInternal() hands out shared_ptr<>s to the one living instance,
   or creates a new one.
 - The creation of a new InternalManager shouldn't count as a reference
   to it, and it mustn't be deleted after the shared_ptr<>s have done
   their work.
 - So static shared_ptr<InternalManager> was the wrong choice,
   since that leads to double deletes.
 - While here, be a little more chatty when loading KPMCore.
6 years ago
Adriaan de Groot 1674c81e9c [libcalamares] Add query for kpmcore status 6 years ago
Adriaan de Groot 7adbc8cda6 [libcalamares] Add KPMCore manager
- This handles cleaning up KPMCore on exit
6 years ago
Adriaan de Groot 8eb04a082e [libcalamares] Move FS-related code to partition service
- only moves one function right now, providing user-visible
   name for filesystem name.
6 years ago
Adriaan de Groot a7a3c4f2d8 [libcalamares] Unused include 6 years ago
Adriaan de Groot 93742a8efe [libcalamares] Reformat new code in partition service 6 years ago
Adriaan de Groot 4b3bb54320 [libcalamares] Move partition-finding into libcalamares
- Moved from KPMHelpers to the partition service
 - The is-partition and find-partition methods that make sense
   in general, are moved to libcalamares.
6 years ago
Adriaan de Groot 3930826e93 [fsresizer] [partition] Drop special cases for kpmcore 3.3.1 6 years ago
Adriaan de Groot 9f0f08b571 [partition] Replace useless qobject_cast
- We know the type of the widget, but were declaring it as
   a QWidget. Just forward-declare the class and be done with it.
6 years ago
Adriaan de Groot ca9f21d805 [libcalamares] Refortmat the partition service 6 years ago
Adriaan de Groot ebc4ebbbcc CI: don't indent namespaces at all 6 years ago
Adriaan de Groot 4202126f34 [fsresizer] [partition] Fix build with moved headers
- PartitionIterator has moved into libcalamares
 - While here, sort and organize #include lines
 - Add using to keep code impact small
6 years ago
Adriaan de Groot 8885611ae3 [libcalamares] Fix build with non-namespaced KPMCore types 6 years ago
Adriaan de Groot d8dc512f45 [libcalamares] Move PartitionIterator to partition service.
- Starting to centralize utility code for partitioning into
   libcalamares instead of scattered and weirdly shared between
   modules.
 - This particular commit breaks compiling the modules, though.
6 years ago
Adriaan de Groot f1822c2adb [partition] [fsresizer] For simplicity, disallow beta KPMcore 6 years ago
Adriaan de Groot 83d296bcd0 Merge branch 'clang-format'
- Update coding style (more braces!) and coding documentation,
   reformat parts. The idea is to go through and re-do the
   coding style across the whole codebase incrementally, but
   systematically, in the next release or two.
6 years ago
Adriaan de Groot 3b146d47d0 CI: Remove mention of cLog from documentation 6 years ago
Adriaan de Groot 5dfc4884b3 [calamares] Increase constness
- The model shouldn't change items at all.
6 years ago
Adriaan de Groot 85845c9b3e [calamares] cLog() isn't a thing, return to cDebug() 6 years ago
Adriaan de Groot a6d7fcdadf [calamares] Reformat the rest of the application 6 years ago
Adriaan de Groot 9235499f7f [calamares] Reformat the progresstree
- add { } to single-line blocks
 - group some includes better
 - lines broken at a different length, some shuffling around of
   parameter lists.
6 years ago
Adriaan de Groot 8053bf6f3a CI: use both tools for code-formatting
- astyle can do some things that clang-format doesn't (e.g.
   adding brackets; you need clang-tidy for that),
 - clang-format does a much nicer job with lambdas and certain
   other constructions,
 - allow passing in directories at a time for formatting.
6 years ago
Adriaan de Groot 54c3adb466 CI: add brackets to one-line blocks
- since we mix Python (indentation is important) with C++ (it isn't),
   having indented one-line blocks which suddenly need {} when a
   statment is added is confusing and error-prone. Instead, make
   the blocks explicit, always, in C++.
6 years ago
Adriaan de Groot 94bea9baaf CI: update documentation of debug-levels 6 years ago
Adriaan de Groot 0a1b27fcfa CI: add clang-format as a tool
- update the style guide to require braces around blocks
 - add a clang-format file that is pretty close to the
   astyle configuration
6 years ago
Adriaan de Groot 39675655a0 [calamares] Tidy up include-guard comments 6 years ago
Adriaan de Groot 0d507ec265 [calamares] Tidy up application code
- remove commented code, fix logging around it
 - misplaced include
6 years ago
Adriaan de Groot 7f968e0c83 Merge branch 'issue-1169'
FIXES #1169
6 years ago
Adriaan de Groot 7bda89dac4 Changes: mention issue number in the notes 6 years ago
Adriaan de Groot 1a29555ce0 Changes: document new partition setting 6 years ago
Adriaan de Groot 74432f698f [partition] Allow the requiredStorage setting to propagate
- store into globalStorage if the welcome module hasn't already done so.
 - this ends up used in PartUtils (via globalStorage).
6 years ago
Adriaan de Groot 20c0256932 CI: update AppImage configs
- Use GiB terminology like the example configs already do,
   to match commit 599b34c7
6 years ago
Adriaan de Groot e6a2cb607f [partition] Add setting for requiredstorage
- If the welcome module isn't used, can set a required amount
   of storage for the installation here.
6 years ago
Adriaan de Groot b5c50c8d04 [partition] Update canBeReplaced
- Use GiB consistently
 - Provide same kind of debugging information as canBeResized()
6 years ago
Adriaan de Groot 79934aa513 [partition] Use GiB consistently in code 6 years ago
Adriaan de Groot 962776804c [libcalamares] Add BytesToGiB (extends BytesToMiB) 6 years ago
Adriaan de Groot acf3dbcdcb [partition] Refactor getting the globalStorage value 6 years ago
Adriaan de Groot 3548792d1b [partition] Improve check canBeResized
- Report the globalSettings name properly (with "GiB")
 - Bail out on bad conversion early.
6 years ago
Adriaan de Groot 830e67fae2 Merge branch 'issue-1168'
FIXES #1168
6 years ago
Adriaan de Groot 64ef331562 Changes: document bugfix 6 years ago
Adriaan de Groot c233bbb23d [libcalamaresui] Handle no-finished-page scenarios
- From an exec section, next() is called automatically when
   all the jobs in that section are done.
 - If there **is** no next section (e.g. there's no finished
   page to show after the exec), then m_steps.at() would assert
   on an out-of-range index.
 - Introdcuce a helper predicate isAtVeryEnd() which handles both
   out-of-range and normal at-the-end scenarios.
 - If there's no page following the exec section, stay with the
   slideshow but update buttons to match the normal last-page
   behavior, and don't ask about cancel (since we're done).
6 years ago
Adriaan de Groot b23f4f3bb0 Merge branch 'issue-1164'
FIXES #1164
6 years ago
Adriaan de Groot 4f221b41d1 [libcalamares] Close stdin on process jobs
- This avoids processes that wait on stdin, and e.g. improves
   reaction to having just "cat" (no file) in a command, or
   a package manager that asks for input.
6 years ago
Adriaan de Groot 4e13f780f1 [libcalamares] Expand tests for runCommand
- try both with and without a working-directory set, this would have
   shown up the problem with bad indentation much earlier.
6 years ago
Adriaan de Groot 7be33b8196 [libcalamares] runCommand doesn't need queue or settings
- JobQueue is only needed to get global settings, which are needed
   when running in the target; for host commands, allow running
   without a queue.
 - Settings is needed for the value of debugsettings; assume if
   there's no settings object, that we're in a test and should
   print debugging information.
6 years ago