From d5f0bdd28c5d906b2452dd04f5b963a7d9e3dfde Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Fri, 31 May 2019 11:37:14 +0200 Subject: [PATCH] [partition] Simplify negative logic - Instead of multiple continue statements to avoid negative cases, state the one positive case instead. --- src/modules/partition/core/PartitionCoreModule.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/modules/partition/core/PartitionCoreModule.cpp b/src/modules/partition/core/PartitionCoreModule.cpp index b098c6ea0..4b23c86e4 100644 --- a/src/modules/partition/core/PartitionCoreModule.cpp +++ b/src/modules/partition/core/PartitionCoreModule.cpp @@ -947,12 +947,7 @@ PartitionCoreModule::revertDevice( Device* dev, bool individualRevert ) QList< Device* > devices; for ( DeviceInfo* const info : m_deviceInfos ) { - // device is a QScopedPointer - if ( !info || info->device.isNull() ) - continue; - if ( info->device->type() != Device::Type::Disk_Device ) - continue; - else + if ( info && !info->device.isNull() && info->device->type() == Device::Type::Disk_Device ) devices.append( info->device.data() ); }