From b5c56fd579f0ed5577f516b2a2a11b5781b96fb0 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Mon, 5 Jul 2021 13:33:09 +0200 Subject: [PATCH] [partition] Clarify comments on boot-flags --- src/modules/partition/core/PartUtils.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/modules/partition/core/PartUtils.cpp b/src/modules/partition/core/PartUtils.cpp index 2f269d37f..22e84a09c 100644 --- a/src/modules/partition/core/PartUtils.cpp +++ b/src/modules/partition/core/PartUtils.cpp @@ -451,13 +451,12 @@ isEfiBootable( const Partition* candidate ) { const auto flags = PartitionInfo::flags( candidate ); - // TODO: with KPMCore 4, this comment is wrong: the flags - // are remapped, and the ESP flag is the same as Boot. #if defined( WITH_KPMCORE4API ) + // In KPMCore4, the flags are remapped, and the ESP flag is the same as Boot. static_assert( KPM_PARTITION_FLAG_ESP == KPM_PARTITION_FLAG( Boot ), "KPMCore API enum changed" ); return flags.testFlag( KPM_PARTITION_FLAG_ESP ); #else - /* If bit 17 is set, old-style Esp flag, it's OK */ + // In KPMCore3, bit 17 is the old-style Esp flag, and it's OK if ( flags.testFlag( KPM_PARTITION_FLAG_ESP ) ) { return true;