From a68a381481f5c912f6d60da58501c6bfc0513abc Mon Sep 17 00:00:00 2001
From: Adriaan de Groot <groot@kde.org>
Date: Thu, 25 Apr 2019 14:15:14 +0200
Subject: [PATCH] [license] Fix compiler warnings

 - out-of-order and incomplete initialization
 - documentation style
 - missing assignment operator
---
 src/modules/license/LicensePage.cpp | 3 ++-
 src/modules/license/LicensePage.h   | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/modules/license/LicensePage.cpp b/src/modules/license/LicensePage.cpp
index 0ed5a6a17..f52c68f63 100644
--- a/src/modules/license/LicensePage.cpp
+++ b/src/modules/license/LicensePage.cpp
@@ -87,8 +87,9 @@ LicenseEntry::isLocal() const
 
 LicensePage::LicensePage(QWidget *parent)
     : QWidget( parent )
-    , ui( new Ui::LicensePage )
     , m_isNextEnabled( false )
+    , m_allLicensesOptional( false )
+    , ui( new Ui::LicensePage )
 {
     ui->setupUi( this );
 
diff --git a/src/modules/license/LicensePage.h b/src/modules/license/LicensePage.h
index c08676f92..e595f7ad8 100644
--- a/src/modules/license/LicensePage.h
+++ b/src/modules/license/LicensePage.h
@@ -51,6 +51,7 @@ struct LicenseEntry
 
     LicenseEntry( const QVariantMap& conf );
     LicenseEntry( const LicenseEntry& ) = default;
+    LicenseEntry& operator=( const LicenseEntry& ) = default;
 
     bool isValid() const { return !m_id.isEmpty(); }
     bool isRequired() const { return m_required; }
@@ -94,7 +95,7 @@ private:
     void updateGlobalStorage( bool v );
 
     bool m_isNextEnabled;
-    bool m_allLicensesOptional;  //< all the licenses passed to setEntries are not-required
+    bool m_allLicensesOptional;  ///< @brief all the licenses passed to setEntries are not-required
 
     Ui::LicensePage* ui;
     QList< LicenseWidget* > m_entries;