From a36afc52df047c8c06539d089f4766fa3df0ce6c Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Fri, 25 Jan 2019 10:01:12 -0500 Subject: [PATCH 01/11] Tests: add command-line options to loadmodule - The testing-application loadmodule gets -g and -j options for loading configurations (although -g is not implemented yet). --- src/calamares/testmain.cpp | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/calamares/testmain.cpp b/src/calamares/testmain.cpp index a8b363209..88f6c804b 100644 --- a/src/calamares/testmain.cpp +++ b/src/calamares/testmain.cpp @@ -51,6 +51,10 @@ handle_args( QCoreApplication& a ) { QCommandLineOption debugLevelOption( QStringLiteral("D"), "Verbose output for debugging purposes (0-8).", "level" ); + QCommandLineOption globalOption( QStringList() << QStringLiteral( "g" ) << QStringLiteral( "global "), + QStringLiteral( "Global settings document" ), "global.yaml" ); + QCommandLineOption jobOption( QStringList() << QStringLiteral( "j" ) << QStringLiteral( "job"), + QStringLiteral( "Job settings document" ), "job.yaml" ); QCommandLineParser parser; parser.setApplicationDescription( "Calamares module tester" ); @@ -58,11 +62,16 @@ handle_args( QCoreApplication& a ) parser.addVersionOption(); parser.addOption( debugLevelOption ); + parser.addOption( globalOption ); + parser.addOption( jobOption ); parser.addPositionalArgument( "module", "Path or name of module to run." ); parser.addPositionalArgument( "config", "Path of job-config file to use.", "[config]"); parser.process( a ); + QString globalSettings( parser.value( globalOption ) ); + QString jobSettings( parser.value( jobOption ) ); + if ( parser.isSet( debugLevelOption ) ) { bool ok = true; @@ -89,7 +98,10 @@ handle_args( QCoreApplication& a ) return ModuleConfig(); // NOTREACHED } - return ModuleConfig( args.first(), args.size() == 2 ? args.at(1) : QString() ); + if ( jobSettings.isEmpty() && ( args.size() == 2 ) ) + jobSettings = args.at(1); + + return ModuleConfig( args.first(), jobSettings ); } From b44fd659868896d633a92f705aebad3d70552d59 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Fri, 25 Jan 2019 10:58:43 -0500 Subject: [PATCH 02/11] [libcalamares] load/save globals in YAML format --- src/libcalamares/GlobalStorage.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/libcalamares/GlobalStorage.h b/src/libcalamares/GlobalStorage.h index 72524ba4f..2c31a8f47 100644 --- a/src/libcalamares/GlobalStorage.h +++ b/src/libcalamares/GlobalStorage.h @@ -60,6 +60,7 @@ public: /// @brief dump keys and values to the debug log void debugDump() const; + /** @brief write as JSON to the given filename * * No tidying, sanitization, or censoring is done -- for instance, @@ -69,6 +70,15 @@ public: */ bool save( const QString& filename ); + /** @brief write as YAML to the given filename + * + * See also save(), above. + */ + bool saveYaml( const QString& filename ); + + /// @brief reads settings from the given filename + bool loadYaml( const QString& filename ); + signals: void changed(); From b3a7545217eb561b16b349e3c41f39ce094d3325 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Fri, 25 Jan 2019 11:43:33 -0500 Subject: [PATCH 03/11] [unpackfs] One more test case --- src/modules/unpackfs/tests/8.global | 4 ++++ src/modules/unpackfs/tests/8.job | 5 +++++ 2 files changed, 9 insertions(+) create mode 100644 src/modules/unpackfs/tests/8.global create mode 100644 src/modules/unpackfs/tests/8.job diff --git a/src/modules/unpackfs/tests/8.global b/src/modules/unpackfs/tests/8.global new file mode 100644 index 000000000..0cb33ce55 --- /dev/null +++ b/src/modules/unpackfs/tests/8.global @@ -0,0 +1,4 @@ +--- +rootMountPoint: /tmp/unpackfs-test-run-rootdir/ +localeConf: + - LANG: nl diff --git a/src/modules/unpackfs/tests/8.job b/src/modules/unpackfs/tests/8.job new file mode 100644 index 000000000..a31068e5d --- /dev/null +++ b/src/modules/unpackfs/tests/8.job @@ -0,0 +1,5 @@ +--- +unpack: + - source: . + sourcefs: ext4 + destination: realdest From 5efbf51ed3681bed2f8589cb123c8799dd606e9a Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Fri, 25 Jan 2019 11:59:17 -0500 Subject: [PATCH 04/11] [libcalamares] Improve naming in implementation - The code in loadYaml was refactored out of the module-descriptor loading code, but the variable names in the implementation were not changed and still strangely specific to the prior task. --- src/libcalamares/utils/YamlUtils.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/libcalamares/utils/YamlUtils.cpp b/src/libcalamares/utils/YamlUtils.cpp index 474ced2a1..e54bdfc94 100644 --- a/src/libcalamares/utils/YamlUtils.cpp +++ b/src/libcalamares/utils/YamlUtils.cpp @@ -173,15 +173,15 @@ loadYaml(const QString& filename, bool* ok) if ( ok ) *ok = false; - QFile descriptorFile( filename ); - QVariant moduleDescriptor; - if ( descriptorFile.exists() && descriptorFile.open( QFile::ReadOnly | QFile::Text ) ) + QFile yamlFile( filename ); + QVariant yamlContents; + if ( yamlFile.exists() && yamlFile.open( QFile::ReadOnly | QFile::Text ) ) { - QByteArray ba = descriptorFile.readAll(); + QByteArray ba = yamlFile.readAll(); try { YAML::Node doc = YAML::Load( ba.constData() ); - moduleDescriptor = CalamaresUtils::yamlToVariant( doc ); + yamlContents = CalamaresUtils::yamlToVariant( doc ); } catch ( YAML::Exception& e ) { @@ -191,13 +191,13 @@ loadYaml(const QString& filename, bool* ok) } - if ( moduleDescriptor.isValid() && - !moduleDescriptor.isNull() && - moduleDescriptor.type() == QVariant::Map ) + if ( yamlContents.isValid() && + !yamlContents.isNull() && + yamlContents.type() == QVariant::Map ) { if ( ok ) *ok = true; - return moduleDescriptor.toMap(); + return yamlContents.toMap(); } return QVariantMap(); From 5e1bcd9b4ae4835ffc6aa8e3055b7488d50ce746 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Mon, 28 Jan 2019 07:50:30 -0500 Subject: [PATCH 05/11] [libcalamares] Stub of saveYaml - This belongs alongside loadYaml, so place it in libcalamares - Doesn't actually save anything yet (it isn't used yet) --- src/libcalamares/GlobalStorage.cpp | 18 +++++++++++++++ src/libcalamares/utils/YamlUtils.cpp | 34 ++++++++++++++++++++++++++++ src/libcalamares/utils/YamlUtils.h | 3 +++ 3 files changed, 55 insertions(+) diff --git a/src/libcalamares/GlobalStorage.cpp b/src/libcalamares/GlobalStorage.cpp index 4f98ea2eb..54331eb3e 100644 --- a/src/libcalamares/GlobalStorage.cpp +++ b/src/libcalamares/GlobalStorage.cpp @@ -21,6 +21,7 @@ #include "JobQueue.h" #include "utils/Logger.h" +#include "utils/YamlUtils.h" #include #include @@ -110,6 +111,23 @@ GlobalStorage::save(const QString& filename) } +bool +GlobalStorage::saveYaml( const QString& filename ) +{ + return CalamaresUtils::saveYaml( filename, m ); +} + +bool +GlobalStorage::loadYaml( const QString& filename ) +{ + bool ok = false; + auto gs = CalamaresUtils::loadYaml( filename, &ok ); + if ( ok ) + m = gs; + return ok; +} + + } // namespace Calamares #ifdef WITH_PYTHON diff --git a/src/libcalamares/utils/YamlUtils.cpp b/src/libcalamares/utils/YamlUtils.cpp index e54bdfc94..80e2a316a 100644 --- a/src/libcalamares/utils/YamlUtils.cpp +++ b/src/libcalamares/utils/YamlUtils.cpp @@ -203,4 +203,38 @@ loadYaml(const QString& filename, bool* ok) return QVariantMap(); } +/// @brief Convenience function writes @p indent times four spaces +static void +writeIndent( QFile& f, int indent ) +{ + while ( indent > 0 ) + f.write( " " ); +} + +/// @brief Recursive helper to dump @p map to file +static bool +dumpYaml( QFile& f, const QVariantMap& map, int indent ) +{ + for ( auto it = map.cbegin(); it != map.cend(); ++it ) + { + writeIndent( f, indent ); + f.write( it.key().toUtf8() ); + f.write( "\n" ); + } + return true; +} + +bool +saveYaml( const QString& filename, const QVariantMap& map ) +{ + QFile f( filename ); + if ( !f.open( QFile::WriteOnly ) ) + return false; + + f.write( "# YAML dump\n---\n" ); + return dumpYaml( f, map, 0 ); +} + + + } // namespace diff --git a/src/libcalamares/utils/YamlUtils.h b/src/libcalamares/utils/YamlUtils.h index 268c0bdc7..49c8d6613 100644 --- a/src/libcalamares/utils/YamlUtils.h +++ b/src/libcalamares/utils/YamlUtils.h @@ -51,6 +51,9 @@ QVariant yamlScalarToVariant( const YAML::Node& scalarNode ); QVariant yamlSequenceToVariant( const YAML::Node& sequenceNode ); QVariant yamlMapToVariant( const YAML::Node& mapNode ); +/// @brief Save a @p map to @p filename as YAML +bool saveYaml( const QString& filename, const QVariantMap& map ); + /** * Given an exception from the YAML parser library, explain * what is going on in terms of the data passed to the parser. From 8789b52cb11fde510e208bbcea502856a7b30dea Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Mon, 28 Jan 2019 07:52:38 -0500 Subject: [PATCH 06/11] Tests: add language and global-settings options - The test-loader can be set to a specific language through the -l option (just like the Python one can) and can load a global configuration file. --- src/calamares/testmain.cpp | 39 +++++++++++++++++++++++++++----------- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/src/calamares/testmain.cpp b/src/calamares/testmain.cpp index 88f6c804b..2ebc1d5b2 100644 --- a/src/calamares/testmain.cpp +++ b/src/calamares/testmain.cpp @@ -26,9 +26,10 @@ #include "utils/YamlUtils.h" #include "modulesystem/Module.h" -#include "Settings.h" +#include "GlobalStorage.h" #include "Job.h" #include "JobQueue.h" +#include "Settings.h" #include #include @@ -37,13 +38,17 @@ #include -struct ModuleConfig : public QPair< QString, QString > +struct ModuleConfig { - ModuleConfig( const QString& a, const QString& b ) : QPair< QString, QString >(a, b) { } - ModuleConfig() : QPair< QString, QString >( QString(), QString() ) { } - - QString moduleName() const { return first; } - QString configFile() const { return second; } + QString moduleName() const { return m_module; } + QString configFile() const { return m_jobConfig; } + QString language() const { return m_language; } + QString globalConfigFile() const { return m_globalConfig; } + + QString m_module; + QString m_jobConfig; + QString m_globalConfig; + QString m_language; } ; static ModuleConfig @@ -55,6 +60,8 @@ handle_args( QCoreApplication& a ) QStringLiteral( "Global settings document" ), "global.yaml" ); QCommandLineOption jobOption( QStringList() << QStringLiteral( "j" ) << QStringLiteral( "job"), QStringLiteral( "Job settings document" ), "job.yaml" ); + QCommandLineOption langOption( QStringList() << QStringLiteral( "l" ) << QStringLiteral( "language" ), + QStringLiteral( "Language (global)" ), "languagecode" ); QCommandLineParser parser; parser.setApplicationDescription( "Calamares module tester" ); @@ -64,14 +71,12 @@ handle_args( QCoreApplication& a ) parser.addOption( debugLevelOption ); parser.addOption( globalOption ); parser.addOption( jobOption ); + parser.addOption( langOption ); parser.addPositionalArgument( "module", "Path or name of module to run." ); parser.addPositionalArgument( "config", "Path of job-config file to use.", "[config]"); parser.process( a ); - QString globalSettings( parser.value( globalOption ) ); - QString jobSettings( parser.value( jobOption ) ); - if ( parser.isSet( debugLevelOption ) ) { bool ok = true; @@ -98,10 +103,11 @@ handle_args( QCoreApplication& a ) return ModuleConfig(); // NOTREACHED } + QString jobSettings( parser.value( jobOption ) ); if ( jobSettings.isEmpty() && ( args.size() == 2 ) ) jobSettings = args.at(1); - return ModuleConfig( args.first(), jobSettings ); + return ModuleConfig{ args.first(), jobSettings, parser.value( globalOption ), parser.value( langOption ) }; } @@ -173,6 +179,17 @@ main( int argc, char* argv[] ) std::unique_ptr< Calamares::Settings > settings_p( new Calamares::Settings( QString(), true ) ); std::unique_ptr< Calamares::JobQueue > jobqueue_p( new Calamares::JobQueue( nullptr ) ); + auto gs = jobqueue_p->globalStorage(); + if ( !module.globalConfigFile().isEmpty() ) + gs->loadYaml( module.globalConfigFile() ); + if ( !module.language().isEmpty() ) + { + QVariantMap vm; + vm.insert( "LANG", module.language() ); + gs->insert( "localeConf", vm ); + } + + cDebug() << "Calamares module-loader testing" << module.moduleName(); Calamares::Module* m = load_module( module ); if ( !m ) From f72d6ca403dff21b29dba09c85b083c9e0969089 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Mon, 28 Jan 2019 08:25:13 -0500 Subject: [PATCH 07/11] [libcalamares] Add very basic test for load/save YAML --- src/libcalamares/Tests.cpp | 10 ++++++++++ src/libcalamares/Tests.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/src/libcalamares/Tests.cpp b/src/libcalamares/Tests.cpp index acf5b03d3..3987976dc 100644 --- a/src/libcalamares/Tests.cpp +++ b/src/libcalamares/Tests.cpp @@ -19,6 +19,7 @@ #include "Tests.h" #include "utils/Logger.h" +#include "utils/YamlUtils.h" #include @@ -57,3 +58,12 @@ LibCalamaresTests::testDebugLevels() } } +void +LibCalamaresTests::testLoadSaveYaml() +{ + QFile f( "settings.conf" ); + QVERIFY( f.exists() ); + + auto map = CalamaresUtils::loadYaml( "settings.conf" ); + CalamaresUtils::saveYaml( "out.yaml", map ); +} diff --git a/src/libcalamares/Tests.h b/src/libcalamares/Tests.h index 123655c6e..19e5a3f0c 100644 --- a/src/libcalamares/Tests.h +++ b/src/libcalamares/Tests.h @@ -31,6 +31,8 @@ public: private Q_SLOTS: void initTestCase(); void testDebugLevels(); + + void testLoadSaveYaml(); }; #endif From e25deffa749836297fa3eb9dc121e7904b141d81 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Mon, 28 Jan 2019 18:25:47 -0500 Subject: [PATCH 08/11] [libcalamares] Implement most of dumpYaml - Write out bools, strings, lists and maps; this is enough to read and reproduce settings.conf - Fix infinite loop in writeIndent() --- src/libcalamares/utils/YamlUtils.cpp | 46 ++++++++++++++++++++++++++-- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/src/libcalamares/utils/YamlUtils.cpp b/src/libcalamares/utils/YamlUtils.cpp index 80e2a316a..48295851c 100644 --- a/src/libcalamares/utils/YamlUtils.cpp +++ b/src/libcalamares/utils/YamlUtils.cpp @@ -207,8 +207,47 @@ loadYaml(const QString& filename, bool* ok) static void writeIndent( QFile& f, int indent ) { - while ( indent > 0 ) - f.write( " " ); + while ( indent-- > 0 ) + f.write( " " ); +} + +// forward declaration +static bool dumpYaml( QFile& f, const QVariantMap& map, int indent ); + +/// @brief Recursive helper to dump a single value +static void +dumpYamlElement( QFile& f, const QVariant& value, int indent ) +{ + if ( value.type() == QVariant::Type::Bool ) + f.write( value.toBool() ? "true" : "false" ); + else if ( value.type() == QVariant::Type::String ) + { + static const char quote[] = "\""; + f.write( quote ); + f.write( value.toString().toUtf8() ); + f.write( quote ); + } + else if ( value.type() == QVariant::Type::List ) + { + int c = 0; + for ( const auto& it : value.toList() ) + { + f.write( "\n" ); + writeIndent( f, indent+1 ); + f.write( "- " ); + dumpYamlElement( f, it, indent+1 ); + } + } + else if ( value.type() == QVariant::Type::Map ) + { + dumpYaml( f, value.toMap(), indent+1 ); + } + else + { + f.write( "<" ); + f.write( value.typeName() ); + f.write( ">" ); + } } /// @brief Recursive helper to dump @p map to file @@ -217,8 +256,9 @@ dumpYaml( QFile& f, const QVariantMap& map, int indent ) { for ( auto it = map.cbegin(); it != map.cend(); ++it ) { - writeIndent( f, indent ); f.write( it.key().toUtf8() ); + f.write( ": " ); + dumpYamlElement( f, it.value(), indent ); f.write( "\n" ); } return true; From 3d6dd1202ab42a2a26ca1f8bdebd18dee1976d61 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Tue, 29 Jan 2019 07:31:29 -0500 Subject: [PATCH 09/11] [libcalamares] Extend tests to all example config files - Do a `find ../src/ -name *.conf` to get files to load - Load and save all of them to check for correctness --- src/libcalamares/Tests.cpp | 42 ++++++++++++++++++++++++++++++++++++++ src/libcalamares/Tests.h | 3 ++- 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/src/libcalamares/Tests.cpp b/src/libcalamares/Tests.cpp index 3987976dc..102a18409 100644 --- a/src/libcalamares/Tests.cpp +++ b/src/libcalamares/Tests.cpp @@ -66,4 +66,46 @@ LibCalamaresTests::testLoadSaveYaml() auto map = CalamaresUtils::loadYaml( "settings.conf" ); CalamaresUtils::saveYaml( "out.yaml", map ); + + auto other_map = CalamaresUtils::loadYaml( "out.yaml" ); + CalamaresUtils::saveYaml(" out2.yaml", other_map ); + QCOMPARE( map, other_map ); + + QFile::remove( "out.yaml" ); + QFile::remove( "out2.yaml" ); +} + +static QStringList +findConf( const QDir& d ) +{ + QStringList mine; + if ( d.exists() ) + { + QString path = d.absolutePath(); + path.append( d.separator() ); + for ( const auto& confname : d.entryList( { "*.conf" } ) ) + mine.append( path + confname ); + for ( const auto& subdirname : d.entryList( QDir::AllDirs | QDir::NoDotAndDotDot ) ) + { + QDir subdir( d ); + subdir.cd( subdirname ); + mine.append( findConf( subdir ) ); + } + } + return mine; +} + + +void +LibCalamaresTests::testLoadSaveYamlExtended() +{ + for ( const auto& confname : findConf( QDir( "../src" ) ) ) + { + cDebug() << "Testing" << confname; + auto map = CalamaresUtils::loadYaml( confname ); + QVERIFY( CalamaresUtils::saveYaml( "out.yaml", map ) ); + auto othermap = CalamaresUtils::loadYaml( "out.yaml" ); + QCOMPARE( map, othermap ); + } + QFile::remove( "out.yaml" ); } diff --git a/src/libcalamares/Tests.h b/src/libcalamares/Tests.h index 19e5a3f0c..8d0aee1ff 100644 --- a/src/libcalamares/Tests.h +++ b/src/libcalamares/Tests.h @@ -32,7 +32,8 @@ private Q_SLOTS: void initTestCase(); void testDebugLevels(); - void testLoadSaveYaml(); + void testLoadSaveYaml(); // Just settings.conf + void testLoadSaveYamlExtended(); // Do a find() in the src dir }; #endif From 958d15fb7128d679962a428b609e9ed38d1372d6 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Tue, 29 Jan 2019 07:47:38 -0500 Subject: [PATCH 10/11] [libcalamares] Improve saveYaml() - Write out Int, Double - Special-case empty lists - Do objects (not lists of objects) correctly Now passes the tests for all the example config files. --- src/libcalamares/utils/YamlUtils.cpp | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/src/libcalamares/utils/YamlUtils.cpp b/src/libcalamares/utils/YamlUtils.cpp index 48295851c..e7eb8fd46 100644 --- a/src/libcalamares/utils/YamlUtils.cpp +++ b/src/libcalamares/utils/YamlUtils.cpp @@ -214,6 +214,10 @@ writeIndent( QFile& f, int indent ) // forward declaration static bool dumpYaml( QFile& f, const QVariantMap& map, int indent ); +// It's a quote +static const char quote[] = "\""; +static const char newline[] = "\n"; + /// @brief Recursive helper to dump a single value static void dumpYamlElement( QFile& f, const QVariant& value, int indent ) @@ -222,24 +226,35 @@ dumpYamlElement( QFile& f, const QVariant& value, int indent ) f.write( value.toBool() ? "true" : "false" ); else if ( value.type() == QVariant::Type::String ) { - static const char quote[] = "\""; f.write( quote ); f.write( value.toString().toUtf8() ); f.write( quote ); } + else if ( value.type() == QVariant::Type::Int ) + { + f.write( QString::number( value.toInt() ).toUtf8() ); + } + else if ( value.type() == QVariant::Type::Double ) + { + f.write( QString::number( value.toDouble() ).toUtf8() ); + } else if ( value.type() == QVariant::Type::List ) { int c = 0; for ( const auto& it : value.toList() ) { - f.write( "\n" ); + ++c; + f.write( newline ); writeIndent( f, indent+1 ); f.write( "- " ); dumpYamlElement( f, it, indent+1 ); } + if ( !c ) // i.e. list was empty + f.write( "[]" ); } else if ( value.type() == QVariant::Type::Map ) { + f.write( newline ); dumpYaml( f, value.toMap(), indent+1 ); } else @@ -256,10 +271,13 @@ dumpYaml( QFile& f, const QVariantMap& map, int indent ) { for ( auto it = map.cbegin(); it != map.cend(); ++it ) { + writeIndent( f, indent ); + f.write( quote ); f.write( it.key().toUtf8() ); + f.write( quote ); f.write( ": " ); dumpYamlElement( f, it.value(), indent ); - f.write( "\n" ); + f.write( newline ); } return true; } From fe0c57c7af7eeaf13f933b8cd8a3bf16353f2192 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Tue, 29 Jan 2019 07:52:45 -0500 Subject: [PATCH 11/11] [calamares] Make loadmodule --help consistent - Name job.yaml consistently, call it "job settings document" --- src/calamares/testmain.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/calamares/testmain.cpp b/src/calamares/testmain.cpp index 2ebc1d5b2..7fcbec666 100644 --- a/src/calamares/testmain.cpp +++ b/src/calamares/testmain.cpp @@ -73,7 +73,7 @@ handle_args( QCoreApplication& a ) parser.addOption( jobOption ); parser.addOption( langOption ); parser.addPositionalArgument( "module", "Path or name of module to run." ); - parser.addPositionalArgument( "config", "Path of job-config file to use.", "[config]"); + parser.addPositionalArgument( "job.yaml", "Path of job settings document to use.", "[job.yaml]"); parser.process( a );