From 8d5fbaafebe73cc67fc1f97236cee96d862be080 Mon Sep 17 00:00:00 2001
From: shainer <syn.shainer@gmail.com>
Date: Mon, 21 Nov 2016 00:32:04 +0000
Subject: [PATCH] New cmake switch to skip installing configuration.

The INSTALL_CONFIG is "on" by default. When set to off,
no *.conf file, both global and related to a single module,
will be installed. A warning message is printed by cmake too,
and the module description is edited to make this visible.

This is useful for testing, when we want to install our
own libraries and binary but keep the configuration of the
live system we are testing on (e.g. path to distro image).

Tested on the master branch.
---
 CMakeLists.txt                       | 19 +++++++++++++------
 CalamaresAddModuleSubdirectory.cmake |  8 ++++++--
 CalamaresAddPlugin.cmake             | 18 ++++++++++++------
 3 files changed, 31 insertions(+), 14 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index c902768c2..561f7bf2d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -57,6 +57,7 @@ find_package( PolkitQt5-1 REQUIRED )
 
 option( WITH_PYTHON "Enable Python modules support." ON )
 option( WITH_CRASHREPORTER "Build with CrashReporter" ON )
+option( INSTALL_CONFIG "Install configuration files" ON)
 
 if( CMAKE_SYSTEM_PROCESSOR MATCHES "arm" OR NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/libcrashreporter-qt/CMakeLists.txt" )
     message( STATUS "Build of crashreporter disabled." )
@@ -170,6 +171,10 @@ if ( NOT WITH_PYTHON )
     message( "-- WARNING: Building Calamares without Python support. Python modules will not work.\n" )
 endif()
 
+if ( NOT INSTALL_CONFIG )
+    message( "-- WARNING: Configuration files will not be installed.\n" )
+endif()
+
 # Add all targets to the build-tree export set
 set( CMAKE_INSTALL_CMAKEDIR "${CMAKE_INSTALL_LIBDIR}/cmake/Calamares" CACHE PATH  "Installation directory for CMake files" )
 set( CMAKE_INSTALL_FULL_CMAKEDIR "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_CMAKEDIR}" )
@@ -211,12 +216,14 @@ install(
         "${CMAKE_INSTALL_CMAKEDIR}"
 )
 
-install(
-    FILES
-        settings.conf
-    DESTINATION
-        share/calamares
-)
+if (INSTALL_CONFIG)
+    install(
+        FILES
+            settings.conf
+        DESTINATION
+            share/calamares
+    )
+endif()
 
 install(
   FILES
diff --git a/CalamaresAddModuleSubdirectory.cmake b/CalamaresAddModuleSubdirectory.cmake
index 73b6bb06f..5e8356e34 100644
--- a/CalamaresAddModuleSubdirectory.cmake
+++ b/CalamaresAddModuleSubdirectory.cmake
@@ -21,7 +21,7 @@ function( calamares_add_module_subdirectory )
                 configure_file( ${SUBDIRECTORY}/${MODULE_FILE} ${SUBDIRECTORY}/${MODULE_FILE} COPYONLY )
 
                 get_filename_component( FLEXT ${MODULE_FILE} EXT )
-                if( "${FLEXT}" STREQUAL ".conf" )
+                if( "${FLEXT}" STREQUAL ".conf" AND INSTALL_CONFIG)
                     install( FILES ${CMAKE_CURRENT_BINARY_DIR}/${SUBDIRECTORY}/${MODULE_FILE}
                              DESTINATION ${MODULE_DATA_DESTINATION} )
                     list( APPEND MODULE_CONFIG_FILES ${MODULE_FILE} )
@@ -38,7 +38,11 @@ function( calamares_add_module_subdirectory )
 #            message( "   ${Green}FILES:${ColorReset} ${MODULE_FILES}" )
             message( "   ${Green}MODULE_DESTINATION:${ColorReset} ${MODULE_DESTINATION}" )
             if( MODULE_CONFIG_FILES )
-                message( "   ${Green}CONFIGURATION_FILES:${ColorReset} ${MODULE_CONFIG_FILES} => ${MODULE_DATA_DESTINATION}" )
+                if (INSTALL_CONFIG)
+                    message( "   ${Green}CONFIGURATION_FILES:${ColorReset} ${MODULE_CONFIG_FILES} => ${MODULE_DATA_DESTINATION}" )
+                else()
+                    message( "   ${Green}CONFIGURATION_FILES:${ColorReset} ${MODULE_CONFIG_FILES} => [Skipping installation]" )
+                endif()
             endif()
             message( "" )
         endif()
diff --git a/CalamaresAddPlugin.cmake b/CalamaresAddPlugin.cmake
index fb9d0086b..9aa6a6872 100644
--- a/CalamaresAddPlugin.cmake
+++ b/CalamaresAddPlugin.cmake
@@ -28,7 +28,11 @@ function( calamares_add_plugin )
 #        message( "   ${Green}NO_INSTALL:${ColorReset} ${PLUGIN_NO_INSTALL}" )
         message( "   ${Green}PLUGIN_DESTINATION:${ColorReset} ${PLUGIN_DESTINATION}" )
         if( PLUGIN_CONFIG_FILES )
-            message( "   ${Green}CONFIGURATION_FILES:${ColorReset} ${PLUGIN_CONFIG_FILES} => ${PLUGIN_DATA_DESTINATION}" )
+            if ( INSTALL_CONFIG )
+                message( "   ${Green}CONFIGURATION_FILES:${ColorReset} ${PLUGIN_CONFIG_FILES} => ${PLUGIN_DATA_DESTINATION}" )
+            else()
+                message( "   ${Green}CONFIGURATION_FILES:${ColorReset} ${PLUGIN_CONFIG_FILES} => [Skipping installation]" )
+            endif()
         endif()
         if( PLUGIN_RESOURCES )
             message( "   ${Green}RESOURCES:${ColorReset} ${PLUGIN_RESOURCES}" )
@@ -78,9 +82,11 @@ function( calamares_add_plugin )
     install( FILES ${CMAKE_CURRENT_BINARY_DIR}/${PLUGIN_DESC_FILE}
              DESTINATION ${PLUGIN_DESTINATION} )
 
-    foreach( PLUGIN_CONFIG_FILE ${PLUGIN_CONFIG_FILES} )
-        configure_file( ${PLUGIN_CONFIG_FILE} ${PLUGIN_CONFIG_FILE} COPYONLY )
-        install( FILES ${CMAKE_CURRENT_BINARY_DIR}/${PLUGIN_CONFIG_FILE}
-                 DESTINATION ${PLUGIN_DATA_DESTINATION} )
-    endforeach()
+    if ( INSTALL_CONFIG )
+        foreach( PLUGIN_CONFIG_FILE ${PLUGIN_CONFIG_FILES} )
+            configure_file( ${PLUGIN_CONFIG_FILE} ${PLUGIN_CONFIG_FILE} COPYONLY )
+            install( FILES ${CMAKE_CURRENT_BINARY_DIR}/${PLUGIN_CONFIG_FILE}
+                     DESTINATION ${PLUGIN_DATA_DESTINATION} )
+        endforeach()
+    endif()
 endfunction()