From 4e7020d0303916c2a555c856a6ab06a0cf54c33f Mon Sep 17 00:00:00 2001
From: Adriaan de Groot <groot@kde.org>
Date: Thu, 2 Apr 2020 22:04:34 +0200
Subject: [PATCH] [libcalamares] Polish model

- make signals consistent in carrying a parameter
- explain why there's no Q_ENUM
---
 src/libcalamares/modulesystem/RequirementsModel.cpp | 2 +-
 src/libcalamares/modulesystem/RequirementsModel.h   | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/libcalamares/modulesystem/RequirementsModel.cpp b/src/libcalamares/modulesystem/RequirementsModel.cpp
index 4cd065dd7..4001d2d81 100644
--- a/src/libcalamares/modulesystem/RequirementsModel.cpp
+++ b/src/libcalamares/modulesystem/RequirementsModel.cpp
@@ -34,7 +34,7 @@ RequirementsModel::setRequirementsList( const Calamares::RequirementsList& requi
     m_satisfiedMandatory = std::none_of( m_requirements.begin(), m_requirements.end(), isMandatoryAndUnSatisfied );
 
     emit satisfiedRequirementsChanged( m_satisfiedRequirements );
-    emit satisfiedMandatoryChanged();
+    emit satisfiedMandatoryChanged( m_satisfiedMandatory );
     emit endResetModel();
 }
 
diff --git a/src/libcalamares/modulesystem/RequirementsModel.h b/src/libcalamares/modulesystem/RequirementsModel.h
index 47f80e3ae..03e00bec5 100644
--- a/src/libcalamares/modulesystem/RequirementsModel.h
+++ b/src/libcalamares/modulesystem/RequirementsModel.h
@@ -46,6 +46,7 @@ public:
         NegatedText,
         HasDetails
     };
+    // No Q_ENUM because these are exposed through roleNames()
 
     bool satisfiedRequirements() const { return m_satisfiedRequirements; }
     bool satisfiedMandatory() const { return m_satisfiedMandatory; }
@@ -76,7 +77,7 @@ private:
 
 signals:
     void satisfiedRequirementsChanged( bool value );
-    void satisfiedMandatoryChanged();
+    void satisfiedMandatoryChanged( bool value );
     void warningMessageChanged();
 };