From 39d618c61e7ecdc9c068c799c26bcf811cd867ae Mon Sep 17 00:00:00 2001
From: Adriaan de Groot <groot@kde.org>
Date: Fri, 5 Jul 2019 13:28:32 +0200
Subject: [PATCH] [initcpio] Simple test for fixPermissions()

---
 src/modules/initcpio/CMakeLists.txt  | 17 ++++++++
 src/modules/initcpio/InitcpioJob.cpp |  2 +-
 src/modules/initcpio/Tests.cpp       | 59 ++++++++++++++++++++++++++++
 src/modules/initcpio/Tests.h         | 36 +++++++++++++++++
 4 files changed, 113 insertions(+), 1 deletion(-)
 create mode 100644 src/modules/initcpio/Tests.cpp
 create mode 100644 src/modules/initcpio/Tests.h

diff --git a/src/modules/initcpio/CMakeLists.txt b/src/modules/initcpio/CMakeLists.txt
index d35a12f06..990220b10 100644
--- a/src/modules/initcpio/CMakeLists.txt
+++ b/src/modules/initcpio/CMakeLists.txt
@@ -7,3 +7,20 @@ calamares_add_plugin( initcpio
         calamares
     SHARED_LIB
 )
+
+if( ECM_FOUND AND BUILD_TESTING )
+    ecm_add_test(
+            Tests.cpp
+        TEST_NAME
+            initcpiotest
+        LINK_LIBRARIES
+            ${CALAMARES_LIBRARIES}
+            calamares
+            calamares_job_initcpio # From above
+            ${YAMLCPP_LIBRARY}
+            Qt5::Core
+            Qt5::Test
+    )
+    set_target_properties( initcpiotest PROPERTIES AUTOMOC TRUE )
+    target_include_directories( initcpiotest PRIVATE /usr/local/include )
+endif()
diff --git a/src/modules/initcpio/InitcpioJob.cpp b/src/modules/initcpio/InitcpioJob.cpp
index 0b96ddcd2..d0d825cbf 100644
--- a/src/modules/initcpio/InitcpioJob.cpp
+++ b/src/modules/initcpio/InitcpioJob.cpp
@@ -40,7 +40,7 @@ InitcpioJob::prettyName() const
     return tr( "Creating initramfs with mkinitcpio." );
 }
 
-static void
+void
 fixPermissions( const QDir& d )
 {
     for ( const auto& fi : d.entryInfoList( { "initramfs*" }, QDir::Files ) )
diff --git a/src/modules/initcpio/Tests.cpp b/src/modules/initcpio/Tests.cpp
new file mode 100644
index 000000000..e0590ba25
--- /dev/null
+++ b/src/modules/initcpio/Tests.cpp
@@ -0,0 +1,59 @@
+/* === This file is part of Calamares - <https://github.com/calamares> ===
+ *
+ *   Copyright 2019, Adriaan de Groot <groot@kde.org>
+ *
+ *   Calamares is free software: you can redistribute it and/or modify
+ *   it under the terms of the GNU General Public License as published by
+ *   the Free Software Foundation, either version 3 of the License, or
+ *   (at your option) any later version.
+ *
+ *   Calamares is distributed in the hope that it will be useful,
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ *   GNU General Public License for more details.
+ *
+ *   You should have received a copy of the GNU General Public License
+ *   along with Calamares. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "Tests.h"
+
+#include "GlobalStorage.h"
+#include "JobQueue.h"
+#include "Settings.h"
+
+#include "utils/Logger.h"
+#include "utils/Yaml.h"
+
+#include <QtTest/QtTest>
+
+#include <QFileInfo>
+#include <QStringList>
+
+extern void fixPermissions( const QDir& d );
+    
+QTEST_GUILESS_MAIN( InitcpioTests )
+
+InitcpioTests::InitcpioTests()
+{
+}
+
+InitcpioTests::~InitcpioTests()
+{
+}
+
+void
+InitcpioTests::initTestCase()
+{
+}
+
+void InitcpioTests::testFixPermissions()
+{
+    Logger::setupLogLevel( Logger::LOGDEBUG );
+    cDebug() << "Fixing up /boot";
+    fixPermissions( QDir( "/boot" ) );
+    cDebug() << "Fixing up /nonexistent";
+    fixPermissions( QDir( "/nonexistent/nonexistent" ) );
+    QVERIFY( true );
+}
+
diff --git a/src/modules/initcpio/Tests.h b/src/modules/initcpio/Tests.h
new file mode 100644
index 000000000..5bab26d3f
--- /dev/null
+++ b/src/modules/initcpio/Tests.h
@@ -0,0 +1,36 @@
+/* === This file is part of Calamares - <https://github.com/calamares> ===
+ *
+ *   Copyright 2019, Adriaan de Groot <groot@kde.org>
+ *
+ *   Calamares is free software: you can redistribute it and/or modify
+ *   it under the terms of the GNU General Public License as published by
+ *   the Free Software Foundation, either version 3 of the License, or
+ *   (at your option) any later version.
+ *
+ *   Calamares is distributed in the hope that it will be useful,
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ *   GNU General Public License for more details.
+ *
+ *   You should have received a copy of the GNU General Public License
+ *   along with Calamares. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef TESTS_H
+#define TESTS_H
+
+#include <QObject>
+
+class InitcpioTests : public QObject
+{
+    Q_OBJECT
+public:
+    InitcpioTests();
+    ~InitcpioTests() override;
+
+private Q_SLOTS:
+    void initTestCase();
+    void testFixPermissions();
+};
+
+#endif