mirror of https://github.com/cutefishos/calamares
Adriaan de Groot
5 years ago
commit
33a4b08ac0
@ -0,0 +1,156 @@
|
||||
/*
|
||||
* Copyright 2016, Luca Giambonini <almack@chakraos.org>
|
||||
* Copyright 2016, Lisa Vitolo <shainer@chakraos.org>
|
||||
* Copyright 2017, Kyle Robbertze <krobbertze@gmail.com>
|
||||
* Copyright 2017-2018, 2020, Adriaan de Groot <groot@kde.org>
|
||||
* Copyright 2017, Gabriel Craciunescu <crazy@frugalware.org>
|
||||
*
|
||||
* Calamares is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* Calamares is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with Calamares. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
#include "Config.h"
|
||||
|
||||
#include "network/Manager.h"
|
||||
#include "utils/Logger.h"
|
||||
#include "utils/Yaml.h"
|
||||
|
||||
#include <QNetworkReply>
|
||||
|
||||
Config::Config( QObject* parent )
|
||||
: QObject( parent )
|
||||
, m_model( new PackageModel( this ) )
|
||||
{
|
||||
}
|
||||
|
||||
Config::~Config() {}
|
||||
|
||||
QString
|
||||
Config::status() const
|
||||
{
|
||||
switch ( m_status )
|
||||
{
|
||||
case Status::Ok:
|
||||
return QString();
|
||||
case Status::FailedBadConfiguration:
|
||||
return tr( "Network Installation. (Disabled: Incorrect configuration)" );
|
||||
case Status::FailedBadData:
|
||||
return tr( "Network Installation. (Disabled: Received invalid groups data)" );
|
||||
case Status::FailedInternalError:
|
||||
return tr( "Network Installation. (Disabled: internal error)" );
|
||||
case Status::FailedNetworkError:
|
||||
return tr( "Network Installation. (Disabled: Unable to fetch package lists, check your network connection)" );
|
||||
}
|
||||
NOTREACHED return QString();
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
Config::setStatus( Status s )
|
||||
{
|
||||
m_status = s;
|
||||
emit statusChanged( status() );
|
||||
}
|
||||
|
||||
void
|
||||
Config::loadGroupList( const QVariantList& groupData )
|
||||
{
|
||||
m_model->setupModelData( groupData );
|
||||
emit statusReady();
|
||||
}
|
||||
|
||||
void
|
||||
Config::loadGroupList( const QUrl& url )
|
||||
{
|
||||
if ( !url.isValid() )
|
||||
{
|
||||
setStatus( Status::FailedBadConfiguration );
|
||||
}
|
||||
|
||||
using namespace CalamaresUtils::Network;
|
||||
|
||||
cDebug() << "NetInstall loading groups from" << url;
|
||||
QNetworkReply* reply = Manager::instance().asynchronousGet(
|
||||
url,
|
||||
RequestOptions( RequestOptions::FakeUserAgent | RequestOptions::FollowRedirect, std::chrono::seconds( 30 ) ) );
|
||||
|
||||
if ( !reply )
|
||||
{
|
||||
cDebug() << Logger::Continuation << "request failed immediately.";
|
||||
setStatus( Status::FailedBadConfiguration );
|
||||
}
|
||||
else
|
||||
{
|
||||
m_reply = reply;
|
||||
connect( reply, &QNetworkReply::finished, this, &Config::receivedGroupData );
|
||||
}
|
||||
}
|
||||
|
||||
/// @brief Convenience to zero out and deleteLater on the reply, used in dataIsHere
|
||||
struct ReplyDeleter
|
||||
{
|
||||
QNetworkReply*& p;
|
||||
|
||||
~ReplyDeleter()
|
||||
{
|
||||
if ( p )
|
||||
{
|
||||
p->deleteLater();
|
||||
}
|
||||
p = nullptr;
|
||||
}
|
||||
};
|
||||
|
||||
void
|
||||
Config::receivedGroupData()
|
||||
{
|
||||
if ( !m_reply || !m_reply->isFinished() )
|
||||
{
|
||||
cWarning() << "NetInstall data called too early.";
|
||||
setStatus( Status::FailedInternalError );
|
||||
return;
|
||||
}
|
||||
|
||||
cDebug() << "NetInstall group data received" << m_reply->size() << "bytes from" << m_reply->url();
|
||||
|
||||
ReplyDeleter d { m_reply };
|
||||
|
||||
// If m_required is *false* then we still say we're ready
|
||||
// even if the reply is corrupt or missing.
|
||||
if ( m_reply->error() != QNetworkReply::NoError )
|
||||
{
|
||||
cWarning() << "unable to fetch netinstall package lists.";
|
||||
cDebug() << Logger::SubEntry << "Netinstall reply error: " << m_reply->error();
|
||||
cDebug() << Logger::SubEntry << "Request for url: " << m_reply->url().toString()
|
||||
<< " failed with: " << m_reply->errorString();
|
||||
setStatus( Status::FailedNetworkError );
|
||||
return;
|
||||
}
|
||||
|
||||
QByteArray yamlData = m_reply->readAll();
|
||||
try
|
||||
{
|
||||
YAML::Node groups = YAML::Load( yamlData.constData() );
|
||||
|
||||
if ( !groups.IsSequence() )
|
||||
{
|
||||
cWarning() << "NetInstall groups data does not form a sequence.";
|
||||
}
|
||||
loadGroupList( CalamaresUtils::yamlSequenceToVariant( groups ) );
|
||||
}
|
||||
catch ( YAML::Exception& e )
|
||||
{
|
||||
CalamaresUtils::explainYamlException( e, yamlData, "netinstall groups data" );
|
||||
setStatus( Status::FailedBadData );
|
||||
}
|
||||
}
|
||||
@ -0,0 +1,87 @@
|
||||
/*
|
||||
* Copyright 2016, Luca Giambonini <almack@chakraos.org>
|
||||
* Copyright 2016, Lisa Vitolo <shainer@chakraos.org>
|
||||
* Copyright 2017, Kyle Robbertze <krobbertze@gmail.com>
|
||||
* Copyright 2017-2018, 2020, Adriaan de Groot <groot@kde.org>
|
||||
*
|
||||
* Calamares is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* Calamares is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with Calamares. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
#ifndef NETINSTALL_CONFIG_H
|
||||
#define NETINSTALL_CONFIG_H
|
||||
|
||||
#include "PackageModel.h"
|
||||
|
||||
#include <QObject>
|
||||
#include <QUrl>
|
||||
|
||||
class QNetworkReply;
|
||||
|
||||
class Config : public QObject
|
||||
{
|
||||
Q_OBJECT
|
||||
|
||||
Q_PROPERTY( PackageModel* packageModel MEMBER m_model FINAL )
|
||||
Q_PROPERTY( QString status READ status NOTIFY statusChanged FINAL )
|
||||
|
||||
public:
|
||||
Config( QObject* parent = nullptr );
|
||||
virtual ~Config();
|
||||
|
||||
enum class Status
|
||||
{
|
||||
Ok,
|
||||
FailedBadConfiguration,
|
||||
FailedInternalError,
|
||||
FailedNetworkError,
|
||||
FailedBadData
|
||||
};
|
||||
|
||||
QString status() const;
|
||||
void setStatus( Status s );
|
||||
|
||||
bool required() const { return m_required; }
|
||||
void setRequired( bool r ) { m_required = r; }
|
||||
|
||||
/** @brief Retrieves the groups, with name, description and packages
|
||||
*
|
||||
* Loads data from the given URL. Once done, the data is parsed
|
||||
* and passed on to the other loadGroupList() method.
|
||||
*/
|
||||
void loadGroupList( const QUrl& url );
|
||||
|
||||
/** @brief Fill model from parsed data.
|
||||
*
|
||||
* Fills the model with a list of groups -- which can contain
|
||||
* subgroups and packages -- from @p groupData.
|
||||
*/
|
||||
void loadGroupList( const QVariantList& groupData );
|
||||
|
||||
PackageModel* model() const { return m_model; }
|
||||
|
||||
signals:
|
||||
void statusChanged( QString status ); ///< Something changed
|
||||
void statusReady(); ///< Loading groups is complete
|
||||
|
||||
private slots:
|
||||
void receivedGroupData(); ///< From async-loading group data
|
||||
|
||||
private:
|
||||
PackageModel* m_model = nullptr;
|
||||
QNetworkReply* m_reply = nullptr; // For fetching data
|
||||
Status m_status = Status::Ok;
|
||||
bool m_required = false;
|
||||
};
|
||||
|
||||
#endif
|
||||
@ -0,0 +1,310 @@
|
||||
/* === This file is part of Calamares - <https://github.com/calamares> ===
|
||||
*
|
||||
* Copyright 2020, Adriaan de Groot <groot@kde.org>
|
||||
*
|
||||
* Calamares is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* Calamares is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with Calamares. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
#include "PackageModel.h"
|
||||
#include "PackageTreeItem.h"
|
||||
|
||||
#include "utils/Logger.h"
|
||||
#include "utils/Variant.h"
|
||||
#include "utils/Yaml.h"
|
||||
|
||||
#include <QtTest/QtTest>
|
||||
|
||||
class ItemTests : public QObject
|
||||
{
|
||||
Q_OBJECT
|
||||
public:
|
||||
ItemTests();
|
||||
virtual ~ItemTests() {}
|
||||
|
||||
private:
|
||||
void checkAllSelected( PackageTreeItem* p );
|
||||
void recursiveCompare( PackageTreeItem*, PackageTreeItem* );
|
||||
void recursiveCompare( PackageModel&, PackageModel& );
|
||||
|
||||
private Q_SLOTS:
|
||||
void initTestCase();
|
||||
|
||||
void testRoot();
|
||||
void testPackage();
|
||||
void testGroup();
|
||||
void testCompare();
|
||||
void testModel();
|
||||
void testExampleFiles();
|
||||
};
|
||||
|
||||
ItemTests::ItemTests() {}
|
||||
|
||||
void
|
||||
ItemTests::initTestCase()
|
||||
{
|
||||
Logger::setupLogLevel( Logger::LOGDEBUG );
|
||||
}
|
||||
|
||||
void
|
||||
ItemTests::testRoot()
|
||||
{
|
||||
PackageTreeItem r;
|
||||
|
||||
QCOMPARE( r.isSelected(), Qt::Checked );
|
||||
QCOMPARE( r.name(), QStringLiteral( "<root>" ) );
|
||||
QCOMPARE( r.parentItem(), nullptr );
|
||||
QVERIFY( r.isGroup() );
|
||||
|
||||
QVERIFY( r == r );
|
||||
}
|
||||
|
||||
void
|
||||
ItemTests::testPackage()
|
||||
{
|
||||
PackageTreeItem p( "bash", nullptr );
|
||||
|
||||
QCOMPARE( p.isSelected(), Qt::Unchecked );
|
||||
QCOMPARE( p.packageName(), QStringLiteral( "bash" ) );
|
||||
QVERIFY( p.name().isEmpty() ); // not a group
|
||||
QCOMPARE( p.parentItem(), nullptr );
|
||||
QCOMPARE( p.childCount(), 0 );
|
||||
QVERIFY( !p.isHidden() );
|
||||
QVERIFY( !p.isCritical() );
|
||||
QVERIFY( !p.isGroup() );
|
||||
QVERIFY( p.isPackage() );
|
||||
QVERIFY( p == p );
|
||||
|
||||
// This doesn't happen in normal constructions,
|
||||
// because a package can't have children.
|
||||
PackageTreeItem c( "zsh", &p );
|
||||
QCOMPARE( c.isSelected(), Qt::Unchecked );
|
||||
QCOMPARE( c.packageName(), QStringLiteral( "zsh" ) );
|
||||
QVERIFY( c.name().isEmpty() ); // not a group
|
||||
QCOMPARE( c.parentItem(), &p );
|
||||
QVERIFY( !c.isGroup() );
|
||||
QVERIFY( c.isPackage() );
|
||||
QVERIFY( c == c );
|
||||
QVERIFY( c != p );
|
||||
|
||||
QCOMPARE( p.childCount(), 0 ); // not noticed it has a child
|
||||
}
|
||||
|
||||
// *INDENT-OFF*
|
||||
// clang-format off
|
||||
static const char doc[] =
|
||||
"- name: \"CCR\"\n"
|
||||
" description: \"Tools for the Chakra Community Repository\"\n"
|
||||
" packages:\n"
|
||||
" - ccr\n"
|
||||
" - base-devel\n"
|
||||
" - bash\n";
|
||||
|
||||
static const char doc_no_packages[] =
|
||||
"- name: \"CCR\"\n"
|
||||
" description: \"Tools for the Chakra Community Repository\"\n"
|
||||
" packages: []\n";
|
||||
|
||||
static const char doc_with_expanded[] =
|
||||
"- name: \"CCR\"\n"
|
||||
" description: \"Tools for the Chakra Community Repository\"\n"
|
||||
" expanded: true\n"
|
||||
" packages:\n"
|
||||
" - ccr\n"
|
||||
" - base-devel\n"
|
||||
" - bash\n";
|
||||
// *INDENT-ON*
|
||||
// clang-format on
|
||||
|
||||
void
|
||||
ItemTests::testGroup()
|
||||
{
|
||||
YAML::Node yamldoc = YAML::Load( doc );
|
||||
QVariantList yamlContents = CalamaresUtils::yamlSequenceToVariant( yamldoc );
|
||||
|
||||
QCOMPARE( yamlContents.length(), 1 );
|
||||
|
||||
PackageTreeItem p( yamlContents[ 0 ].toMap(), nullptr );
|
||||
QCOMPARE( p.name(), QStringLiteral( "CCR" ) );
|
||||
QVERIFY( p.packageName().isEmpty() );
|
||||
QVERIFY( p.description().startsWith( QStringLiteral( "Tools " ) ) );
|
||||
QCOMPARE( p.parentItem(), nullptr );
|
||||
QVERIFY( !p.isHidden() );
|
||||
QVERIFY( !p.isCritical() );
|
||||
// The item-constructor doesn't consider the packages: list
|
||||
QCOMPARE( p.childCount(), 0 );
|
||||
QVERIFY( p.isGroup() );
|
||||
QVERIFY( !p.isPackage() );
|
||||
QVERIFY( p == p );
|
||||
|
||||
PackageTreeItem c( "zsh", nullptr );
|
||||
QVERIFY( p != c );
|
||||
}
|
||||
|
||||
void
|
||||
ItemTests::testCompare()
|
||||
{
|
||||
PackageTreeItem p0( "bash", nullptr );
|
||||
PackageTreeItem p1( "bash", &p0 );
|
||||
PackageTreeItem p2( "bash", nullptr );
|
||||
|
||||
QVERIFY( p0 == p1 ); // Parent doesn't matter
|
||||
QVERIFY( p0 == p2 );
|
||||
|
||||
p2.setSelected( Qt::Checked );
|
||||
p1.setSelected( Qt::Unchecked );
|
||||
QVERIFY( p0 == p1 ); // Neither does selected state
|
||||
QVERIFY( p0 == p2 );
|
||||
|
||||
PackageTreeItem r0( nullptr );
|
||||
QVERIFY( p0 != r0 );
|
||||
QVERIFY( p1 != r0 );
|
||||
QVERIFY( r0 == r0 );
|
||||
PackageTreeItem r1( nullptr );
|
||||
QVERIFY( r0 == r1 ); // Different roots are still equal
|
||||
|
||||
PackageTreeItem r2( "<root>", nullptr ); // Fake root
|
||||
QVERIFY( r0 != r2 );
|
||||
QVERIFY( r1 != r2 );
|
||||
QVERIFY( p0 != r2 );
|
||||
PackageTreeItem r3( "<root>", nullptr );
|
||||
QVERIFY( r3 == r2 );
|
||||
|
||||
YAML::Node yamldoc = YAML::Load( doc ); // See testGroup()
|
||||
QVariantList yamlContents = CalamaresUtils::yamlSequenceToVariant( yamldoc );
|
||||
QCOMPARE( yamlContents.length(), 1 );
|
||||
|
||||
PackageTreeItem p3( yamlContents[ 0 ].toMap(), nullptr );
|
||||
QVERIFY( p3 == p3 );
|
||||
QVERIFY( p3 != p1 );
|
||||
QVERIFY( p1 != p3 );
|
||||
QCOMPARE( p3.childCount(), 0 ); // Doesn't load the packages: list
|
||||
|
||||
PackageTreeItem p4( CalamaresUtils::yamlSequenceToVariant( YAML::Load( doc ) )[ 0 ].toMap(), nullptr );
|
||||
QVERIFY( p3 == p4 );
|
||||
PackageTreeItem p5( CalamaresUtils::yamlSequenceToVariant( YAML::Load( doc_no_packages ) )[ 0 ].toMap(), nullptr );
|
||||
QVERIFY( p3 == p5 );
|
||||
}
|
||||
|
||||
void
|
||||
ItemTests::checkAllSelected( PackageTreeItem* p )
|
||||
{
|
||||
QVERIFY( p->isSelected() );
|
||||
for ( int i = 0; i < p->childCount(); ++i )
|
||||
{
|
||||
checkAllSelected( p->child( i ) );
|
||||
}
|
||||
}
|
||||
|
||||
void
|
||||
ItemTests::recursiveCompare( PackageTreeItem* l, PackageTreeItem* r )
|
||||
{
|
||||
QVERIFY( l && r );
|
||||
QVERIFY( *l == *r );
|
||||
QCOMPARE( l->childCount(), r->childCount() );
|
||||
|
||||
for ( int i = 0; i < l->childCount(); ++i )
|
||||
{
|
||||
QCOMPARE( l->childCount(), r->childCount() );
|
||||
recursiveCompare( l->child( i ), r->child( i ) );
|
||||
}
|
||||
}
|
||||
|
||||
void
|
||||
ItemTests::recursiveCompare( PackageModel& l, PackageModel& r )
|
||||
{
|
||||
return recursiveCompare( l.m_rootItem, r.m_rootItem );
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
ItemTests::testModel()
|
||||
{
|
||||
YAML::Node yamldoc = YAML::Load( doc ); // See testGroup()
|
||||
QVariantList yamlContents = CalamaresUtils::yamlSequenceToVariant( yamldoc );
|
||||
QCOMPARE( yamlContents.length(), 1 );
|
||||
|
||||
PackageModel m0( nullptr );
|
||||
m0.setupModelData( yamlContents );
|
||||
|
||||
QCOMPARE( m0.m_hiddenItems.count(), 0 ); // Nothing hidden
|
||||
QCOMPARE( m0.rowCount(), 1 ); // Group, the packages are invisible
|
||||
QCOMPARE( m0.rowCount( m0.index( 0, 0 ) ), 3 ); // The packages
|
||||
|
||||
checkAllSelected( m0.m_rootItem );
|
||||
|
||||
PackageModel m2( nullptr );
|
||||
m2.setupModelData( CalamaresUtils::yamlSequenceToVariant( YAML::Load( doc_with_expanded ) ) );
|
||||
QCOMPARE( m2.m_hiddenItems.count(), 0 );
|
||||
QCOMPARE( m2.rowCount(), 1 ); // Group, now the packages expanded but not counted
|
||||
QCOMPARE( m2.rowCount( m2.index( 0, 0 ) ), 3 ); // The packages
|
||||
checkAllSelected( m2.m_rootItem );
|
||||
|
||||
PackageTreeItem r;
|
||||
QVERIFY( r == *m0.m_rootItem );
|
||||
|
||||
QCOMPARE( m0.m_rootItem->childCount(), 1 );
|
||||
|
||||
PackageTreeItem* group = m0.m_rootItem->child( 0 );
|
||||
QVERIFY( group->isGroup() );
|
||||
QCOMPARE( group->name(), QStringLiteral( "CCR" ) );
|
||||
QCOMPARE( group->childCount(), 3 );
|
||||
|
||||
PackageTreeItem bash( "bash", nullptr );
|
||||
// Check that the sub-packages loaded correctly
|
||||
bool found_one_bash = false;
|
||||
for ( int i = 0; i < group->childCount(); ++i )
|
||||
{
|
||||
QVERIFY( group->child( i )->isPackage() );
|
||||
if ( bash == *( group->child( i ) ) )
|
||||
{
|
||||
found_one_bash = true;
|
||||
}
|
||||
}
|
||||
QVERIFY( found_one_bash );
|
||||
|
||||
// But m2 has "expanded" set which the others do no
|
||||
QVERIFY( *( m2.m_rootItem->child( 0 ) ) != *group );
|
||||
}
|
||||
|
||||
void
|
||||
ItemTests::testExampleFiles()
|
||||
{
|
||||
QVERIFY( QStringLiteral( BUILD_AS_TEST ).endsWith( "/netinstall" ) );
|
||||
|
||||
QDir d( BUILD_AS_TEST );
|
||||
|
||||
for ( const QString& filename : QStringList { "netinstall.yaml" } )
|
||||
{
|
||||
QFile f( d.filePath( filename ) );
|
||||
QVERIFY( f.exists() );
|
||||
QVERIFY( f.open( QIODevice::ReadOnly ) );
|
||||
QByteArray contents = f.readAll();
|
||||
QVERIFY( !contents.isEmpty() );
|
||||
|
||||
YAML::Node yamldoc = YAML::Load( contents.constData() );
|
||||
QVariantList yamlContents = CalamaresUtils::yamlSequenceToVariant( yamldoc );
|
||||
|
||||
PackageModel m1( nullptr );
|
||||
m1.setupModelData( yamlContents );
|
||||
|
||||
// TODO: should test *something* about this file :/
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
QTEST_GUILESS_MAIN( ItemTests )
|
||||
|
||||
#include "utils/moc-warnings.h"
|
||||
|
||||
#include "Tests.moc"
|
||||
Loading…
Reference in New Issue