From 2cdfe3543015f641fc11655cee3f9b0cedfe1eca Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Sat, 23 Feb 2019 17:14:52 -0500 Subject: [PATCH] [welcome] Avoid threading warnings - The NAM is being created from a method call on the GeneralRequirements object in the requirements-checking thread, while the GR object itself was created in a different thread. This cross-thread parenting produces a warning, and we don't need the parent relationship here anyway. --- src/modules/welcome/checker/GeneralRequirements.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/welcome/checker/GeneralRequirements.cpp b/src/modules/welcome/checker/GeneralRequirements.cpp index 6aba2a2e9..0a841eca1 100644 --- a/src/modules/welcome/checker/GeneralRequirements.cpp +++ b/src/modules/welcome/checker/GeneralRequirements.cpp @@ -346,7 +346,7 @@ bool GeneralRequirements::checkHasInternet() { // default to true in the QNetworkAccessManager::UnknownAccessibility case - QNetworkAccessManager qnam( this ); + QNetworkAccessManager qnam; bool hasInternet = qnam.networkAccessible() == QNetworkAccessManager::Accessible; if ( !hasInternet && qnam.networkAccessible() == QNetworkAccessManager::UnknownAccessibility )