diff --git a/src/modules/finished/FinishedViewStep.cpp b/src/modules/finished/FinishedViewStep.cpp index 310dda25a..1469262a0 100644 --- a/src/modules/finished/FinishedViewStep.cpp +++ b/src/modules/finished/FinishedViewStep.cpp @@ -29,7 +29,7 @@ FinishedViewStep::FinishedViewStep( QObject* parent ) : Calamares::ViewStep( parent ) , m_config( new Config( this ) ) , m_widget( new FinishedPage() ) - , installFailed( false ) + , m_installFailed( false ) { auto jq = Calamares::JobQueue::instance(); connect( jq, &Calamares::JobQueue::failed, m_widget, &FinishedPage::onInstallationFailed ); @@ -94,7 +94,7 @@ FinishedViewStep::sendNotification() { // If the installation failed, don't send notification popup; // there's a (modal) dialog popped up with the failure notice. - if ( installFailed ) + if ( m_installFailed ) { return; } @@ -151,7 +151,7 @@ FinishedViewStep::onInstallationFailed( const QString& message, const QString& d { Q_UNUSED( message ) Q_UNUSED( details ) - installFailed = true; + m_installFailed = true; } void diff --git a/src/modules/finished/FinishedViewStep.h b/src/modules/finished/FinishedViewStep.h index aa71ab38a..ac54fdd35 100644 --- a/src/modules/finished/FinishedViewStep.h +++ b/src/modules/finished/FinishedViewStep.h @@ -50,16 +50,18 @@ public slots: void onInstallationFailed( const QString& message, const QString& details ); private: - Config* m_config; - FinishedPage* m_widget; - /** - * @brief At the end of installation (when this step is activated), - * send a desktop notification via DBus that the install is done. + * @brief Send notification at the end via DBus + * + * At the end of installation (when this step is activated), + * send a desktop notification via DBus that the install is done. + * If the installation failed, no notification is sent. */ void sendNotification(); - bool installFailed; + Config* m_config; + FinishedPage* m_widget; + bool m_installFailed; // Track if onInstallationFailed() was called }; CALAMARES_PLUGIN_FACTORY_DECLARATION( FinishedViewStepFactory )