Fixes: NB#288982 - COREWEB: booster '__assert_fail append_pending_request _XReply'

RevBy: Juha Lintula

debian/changelog

@@ -1,5 +1,6 @@
-applauncherd (2.0.14) unstable; urgency=low
+applauncherd (2.0.14) stable; urgency=low
 
+  * Fixes: NB#288982 - COREWEB: booster '__assert_fail append_pending_request _XReply'
   * Changes: updated some test cases in art-tests and test package dependencies
   * Changes: improve perf test to detect failure
 

src/qdeclarativebooster/mdeclarativecache.cpp

@@ -44,7 +44,8 @@ MDeclarativeCachePrivate::MDeclarativeCachePrivate() :
     initialArgv(new char* [initialArgc]),
     appDirPath(QString()),
     appFilePath(QString()),
-    cachePopulated(false)
+    cachePopulated(false),
+    testabilityInterface(0)
 {
 }
 

src/single-instance/main.cpp

@@ -217,8 +217,6 @@ Window windowIdForBinary(Display *dpy, const char *binaryName)
         unsigned long  nItems = 0;
         unsigned long  bytesAfter;
         unsigned char *prop = 0;
-        char           **wmCommand = NULL;
-        int            wmCommandCount = 0;
 
         // Get the client list of the root window
         int status = XGetWindowProperty(dpy, XDefaultRootWindow(dpy), netClientListAtom,
@@ -230,17 +228,22 @@ Window windowIdForBinary(Display *dpy, const char *binaryName)
             Window * clients = reinterpret_cast<Window *>(prop);
             for (unsigned long i = 0; i < nItems; i++) 
             {
+                char **wmCommand = NULL;
+                int  wmCommandCount = 0;
+
                 if (binaryNameForPid(windowPid(dpy, clients[i])) == binaryName ||
                     (XGetCommand (dpy, clients[i], &wmCommand, &wmCommandCount) != 0 && 
                      wmCommandCount > 0 && strcmp(wmCommand[0], binaryName) == 0))
                 {
                     retValue = clients[i];
-                    break;
                 }
 
                 if (wmCommand) {
                     XFreeStringList(wmCommand);
                 }
+
+                if (retValue)
+                    break;
             }
             
             XFree(prop);