diff --git a/app/src/main/java/com/fox2code/mmm/NotificationType.java b/app/src/main/java/com/fox2code/mmm/NotificationType.java index 7b40686..8df26ba 100644 --- a/app/src/main/java/com/fox2code/mmm/NotificationType.java +++ b/app/src/main/java/com/fox2code/mmm/NotificationType.java @@ -32,9 +32,15 @@ public enum NotificationType implements NotificationTypeCst { return !MainApplication.isShowcaseMode(); } }, - NO_ROOT(R.string.fail_root_magisk, R.drawable.ic_baseline_numbers_24, v -> { - IntentHelper.openUrl(v.getContext(), "https://github.com/topjohnwu/Magisk/blob/master/docs/install.md"); - }) { + NO_MAGISK(R.string.fail_magisk_missing, R.drawable.ic_baseline_numbers_24, v -> + IntentHelper.openUrl(v.getContext(), + "https://github.com/topjohnwu/Magisk/blob/master/docs/install.md")) { + @Override + public boolean shouldRemove() { + return InstallerInitializer.getErrorNotification() != this; + } + }, + NO_ROOT(R.string.fail_root_magisk, R.drawable.ic_baseline_numbers_24) { @Override public boolean shouldRemove() { return InstallerInitializer.getErrorNotification() != this; diff --git a/app/src/main/java/com/fox2code/mmm/installer/InstallerInitializer.java b/app/src/main/java/com/fox2code/mmm/installer/InstallerInitializer.java index 14ad586..d5af961 100644 --- a/app/src/main/java/com/fox2code/mmm/installer/InstallerInitializer.java +++ b/app/src/main/java/com/fox2code/mmm/installer/InstallerInitializer.java @@ -48,7 +48,9 @@ public class InstallerInitializer extends Shell.Initializer { hasRoot != Boolean.FALSE) { return null; } - if (hasRoot != Boolean.TRUE && HAS_MAGISK) { + if (!HAS_MAGISK) { + return NotificationType.NO_MAGISK; + } else if (hasRoot != Boolean.TRUE) { return NotificationType.ROOT_DENIED; } return NotificationType.NO_ROOT; diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 23c30d2..229a7f4 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -3,6 +3,7 @@ Fox\'s Mmm Could not access either Root or Magisk Root has been denied via the Magisk app + Magisk is not installed on this device Loading… Upgradable Installed